🐛fix: removes use of slices.DeleteFunc because it zeros the elements a… #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd doesn't remove those from obj list
faiq
changed the title
dkoshkin
reviewed
Nov 4, 2024
Comment on lines
+348
to
+354
| newObjs := []unstructured.Unstructured{} | ||
| for _, o := range objs { | ||
| if !(o.GetKind() == "Endpoints" || o.GetKind() == "EndpointSlice") { | ||
| newObjs = append(newObjs, o) | ||
| } | ||
| } | ||
| objs = newObjs |
There was a problem hiding this comment.
nit: is this easier to read?
Suggested change
| newObjs := []unstructured.Unstructured{} | |
| for _, o := range objs { | |
| if !(o.GetKind() == "Endpoints" || o.GetKind() == "EndpointSlice") { | |
| newObjs = append(newObjs, o) | |
| } | |
| } | |
| objs = newObjs | |
| // skip resources generated by the Kubernetes API | |
| // this is relevant if the versions are the same, because we compare | |
| // the number of objects when version of objects are equal | |
| newObjs := []unstructured.Unstructured{} | |
| for _, o := range objs { | |
| if o.GetKind() == "Endpoints" || o.GetKind() == "EndpointSlice" { | |
| contiune | |
| } | |
| newObjs = append(newObjs, o) | |
| } | |
| objs = newObjs |
There was a problem hiding this comment.
hmm i guess the boolean logic there is a little confusing but it reads in less lines?
dkoshkin
approved these changes
Nov 4, 2024
supershal
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd doesn't remove those from obj list
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #