🐛 [cherrypick] Set nofile ulimit for loadbalancer container #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
changed the title
|
I like this change; it's specific to the CAPD HAproxy container. I think it hasn't been merged yet upstream because the value ( |
|
I described the root cause in kubernetes-sigs/kind#2954 (comment). Cluster API adopted this change in kubernetes-sigs#8246. Therefore, let's please not carry this when we move to the next upstream release branch. |
takirala
pushed a commit
that referenced
this pull request
Apr 13, 2023
Co-authored-by: killianmuldoon <[email protected]>
dkoshkin
pushed a commit
that referenced
this pull request
Jun 27, 2023
dkoshkin
pushed a commit
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cherrypick kubernetes-sigs#7344 to fix Docker provider HAProxy LB consuming too much memory.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #