Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opsportal: fix a typo that prevents upgrades #655

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Jun 22, 2020

Signed-off-by: Dimitri Koshkin [email protected]

What type of PR is this?

Bug

What this PR does/ why we need it:

Upgrade fails with below, installs worked:

2020-06-22T16:07:47.730Z	ERROR	kubeaddons-controller.Addon	could not upgrade addon	{"Addon": "opsportal", "namespace": "kubeaddons", "chart": "opsportal", "version": "0.3.18", "valuesCRC32": "6ba99a12", "error": "error running cli command `helm upgrade`. stdout: `UPGRADE FAILED\nError: failed to create patch: failed to create two-way merge patch: unable to find api field in struct ObjectMeta for the json field \"lables\" && failed to create patch: failed to create two-way merge patch: unable to find api field in struct ObjectMeta for the json field \"lables\" && failed to create patch: failed to create two-way merge patch: unable to find api field in struct ObjectMeta for the json field \"lables\"\nROLLING BACK`, stderr: `Error: failed to create patch: failed to create two-way merge patch: unable to find api field in struct ObjectMeta for the json field \"lables\" && failed to create patch: failed to create two-way merge patch: unable to find api field in struct ObjectMeta for the json field \"lables\" && failed to create patch: failed to create two-way merge patch: unable to find api field in struct ObjectMeta for the json field \"lables\"\n`: exit status 1"}
github.com/go-logr/zapr.(*zapLogger).Error
	/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
github.com/mesosphere/kubeaddons/internal/drivers/helm/v2.(*helm).upgrade
	/teamcity/work/d942945122290248/internal/drivers/helm/v2/v2.go:311
github.com/mesosphere/kubeaddons/internal/drivers/helm/v2.(*helm).Deploy
	/teamcity/work/d942945122290248/internal/drivers/helm/v2/v2.go:193
github.com/mesosphere/kubeaddons/internal/controllers.(*CommonAddonReconciler).deploy
	/teamcity/work/d942945122290248/internal/controllers/addon_controller.go:273
github.com/mesosphere/kubeaddons/internal/controllers.(*CommonAddonReconciler).reconcile
	/teamcity/work/d942945122290248/internal/controllers/addon_controller.go:247
github.com/mesosphere/kubeaddons/internal/controllers.(*AddonReconciler).Reconcile
	/teamcity/work/d942945122290248/internal/controllers/addon_controller.go:104
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:256
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:88

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

opsportal: fix a typo that prevented upgrades from an older version 

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@dkoshkin dkoshkin added the ready ready label Jun 22, 2020
@dkoshkin dkoshkin requested review from a team as code owners June 22, 2020 18:49
@dkoshkin dkoshkin self-assigned this Jun 22, 2020
Copy link
Contributor

@jr0d jr0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lables... 🤦

@jr0d jr0d merged commit 132c166 into master Jun 22, 2020
@jr0d jr0d deleted the dkoshkin-opsportal-typo branch June 22, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants