Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex-k8s-authenticator: stop using subPath in general for dex-k8s-auth #62

Merged
merged 2 commits into from
Jul 24, 2019
Merged

dex-k8s-authenticator: stop using subPath in general for dex-k8s-auth #62

merged 2 commits into from
Jul 24, 2019

Conversation

hectorj2f
Copy link

I proposed to stay away of subPath volumes in general to avoid issues when mounting/unmounting vols on multiple OS and environments.
related issues:
kubernetes/kubernetes#50345
kubernetes/kubernetes#72991 (comment)
also this one #60

@hectorj2f hectorj2f added the wip label Jul 23, 2019
@hectorj2f hectorj2f self-assigned this Jul 23, 2019
@hectorj2f hectorj2f force-pushed the hectorj2f/avoid_subpath_deploy branch 2 times, most recently from d892f2f to 8155b2e Compare July 24, 2019 11:48
@hectorj2f hectorj2f requested review from dkoshkin and shaneutt July 24, 2019 11:48
@hectorj2f hectorj2f added ready ready and removed wip labels Jul 24, 2019
@hectorj2f hectorj2f requested a review from mhrabovcin July 24, 2019 11:51
mhrabovcin
mhrabovcin approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@mhrabovcin mhrabovcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could contribute this upstream?

@hectorj2f hectorj2f force-pushed the hectorj2f/avoid_subpath_deploy branch from 8155b2e to cf2cd30 Compare July 24, 2019 11:54
shaneutt
shaneutt approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change. I agree we should probably try to upstream this, but I'm OK with spinning up a JIRA to do that later in favor of our immediate priorities if that's your preference.

@hectorj2f
Copy link
Author

Maybe we could contribute this upstream?

Yeah, I agree we can make this change upstream. Let's do it after GA :).

@hectorj2f hectorj2f merged commit 083f74f into dev Jul 24, 2019
@hectorj2f hectorj2f deleted the hectorj2f/avoid_subpath_deploy branch July 24, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin approved these changes

@shaneutt shaneutt shaneutt approved these changes

@dkoshkin dkoshkin Awaiting requested review from dkoshkin

Assignees

@hectorj2f hectorj2f

Labels
ready ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorj2f @mhrabovcin @shaneutt