Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex-k8s-authenticator: avoid using subPath for the secret #60

Merged
merged 2 commits into from
Jul 22, 2019
Merged

dex-k8s-authenticator: avoid using subPath for the secret #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74dab62
dex-k8s-authenticator: avoid using subPath for the secret
Jul 22, 2019
f21175f
dex-k8s-authenticator: fix lint errors
Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions staging/dex-k8s-authenticator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,10 @@ apiVersion: v1
appVersion: "v1.1.0"
description: "Authenticator for using Dex with Kubernetes"
name: dex-k8s-authenticator
version: 1.1.3
version: 1.1.4
home: https://github.com/mesosphere/charts
sources:
- https://github.com/mintel/dex-k8s-authenticator
maintainers:
- name: Martin Hrabovcin
- name: mhrabovcin
email: [email protected]
# Original maintainers from `mintel/dex-k8s-authenticator` repository
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove these maintainers bc the lint check was complaining that the names weren't associated to usernames in gh.

- name: Aaron Roydhouse
email: [email protected]
- name: Nick Badger
email: [email protected]
6 changes: 4 additions & 2 deletions staging/dex-k8s-authenticator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ spec:
{{- if .Values.caCerts.enabled }}
{{- range .Values.caCerts.secrets }}
- name: {{ template "dex-k8s-authenticator.fullname" $ }}-{{ .name }}
subPath: {{ .name }}
mountPath: /certs/{{ .filename }}
mountPath: /certs/
{{- end }}
{{- end }}
resources:
Expand Down Expand Up @@ -93,5 +92,8 @@ spec:
- name: {{ template "dex-k8s-authenticator.fullname" $ }}-{{ .name }}
secret:
secretName: {{ template "dex-k8s-authenticator.fullname" $ }}-{{ .name }}
items:
- key: {{ .name }}
path: {{ .filename }}
{{- end }}
{{- end }}
20 changes: 10 additions & 10 deletions staging/dex-k8s-authenticator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ dexK8sAuthenticator:
periodSeconds: 10
initialDelaySeconds: 10
web_path_prefix: /
#logoUrl: http://<path-to-your-logo.png>
#tlsCert: /path/to/dex-client.crt
#tlsKey: /path/to/dex-client.key
# logoUrl: http://<path-to-your-logo.png>
# tlsCert: /path/to/dex-client.crt
# tlsKey: /path/to/dex-client.key
clusters:
- name: my-cluster
short_description: "My Cluster"
Expand Down Expand Up @@ -84,13 +84,13 @@ caCerts:
#
# value: The base64 encoded value of the CA
#
#secrets:
#- name: ca-cert1
# filename: ca1.crt
# value: LS0tLS1......X2F
#- name: ca-cert2
# filename: ca2.crt
# value: DS1tFA1......X2F
# secrets:
# - name: ca-cert1
# filename: ca1.crt
# value: LS0tLS1......X2F
# - name: ca-cert2
# filename: ca2.crt
# value: DS1tFA1......X2F


nodeSelector: {}
Expand Down