fix: remove logo and brand link #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nothing quite like reviewing minified html + css |
s12chung
suggested changes
Jul 19, 2019
There was a problem hiding this comment.
please bump up the version here:
charts/stable/opsportal/Chart.yaml
Line 5 in 7415ab0
|
What happened to the html resource file page i created and why did we go back to using a line in the chart directly in the configmap? Also can you add me as a maintainer of this chart? |
|
@alejandroEsc I didn't see the this code was written late last night and the landing is a temporary stopgap until we find a better solution. |
s12chung
approved these changes
Jul 19, 2019
|
Please, rebase against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove branded assets on landing page.