kommander: Bump kommander-karma and kommander-thanos deps #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.d2iq.com/browse/D2IQ-64099
Bumps the
kommander-thanos
andkommander-karma
dependencies to pull in the latest changes which added the secret reloader annotations.The following needs to be done (with #438 merge):
mtls-proxy
used inkommander-thanos
andkommander-karma
and add thesecret.reloader.stakater.com/reload
annotations ✅ DONE IN [kommander-karma] [kommander-thanos] Add secret reloader annotations #443kommander-thanos
andkommander-karma
inkommander
chart to pull in the latest changes from the above ✅ DONE IN THIS PRkubeaddons-kommander
Testing
I tested this manually by hosting
mtls-proxy
,kommander-thanos
,kommander-karma
, andkommander charts
on my personal GH. Ikonvoy up
on addons versionmaster
, then upgraded the kommander chart by deploying addons with mykubeaddons-kommander
branchgracedo/bug_certs_D2IQ-64099
.Upon upgrading, I verified that updated secrets were federated out to the managed clusters (as they were before) then checked that the proxies now had the reloader annotation:


I checked Thanos and Karma UIs in the kommander cluster and saw that they were still able to connect to the proxies even after upgrading

