-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add traefik 2 chart #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem approving this, just want to konw if we rather "subchart" or not and keep on a hold pattern until we figure out how we want to maintain charts moving forward. Up to you, i wont block.
I personally have resistance to moving to Traefik 2.0 just yet. Maybe we end up with Traefik 2.0 but I want to run a comparison between Nginx, Traefik, and Envoy before making this move. The reason being ingress is an important component and any change would probably be a big undertaking both in terms of development and operation (upgrades and all). I also didn't like the direction that Traefik 2.0 took with custom CRDs which is a big departure from Kubernetes ingress APIs. I would like to know what approach Nginx and Envoy have taken |
This is just adding the chart for hosting. It's not modified from upstream in any way and I have no plans on moving forward with creating an addon at this time. I am going to do some testing of it on my home cluster though. |
Copy in the upstream chart: [email protected]:containous/traefik-helm-chart.git The chart isn't served by them so this is for us to start with.
84e0059
to
d76bc36
Compare
[Traefik](https://traefik.io/) is a modern HTTP reverse proxy and load balancer made to deploy | ||
microservices with ease. | ||
|
||
**NOTE: THIS CHART IS IN INCUBATOR STATUS, DO NOT USE IN A PRODUCTION ENVIRONMENT** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scary note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No addons will be created from this today. @joejulian wants to test this out. I am also using this chart as a test bed for a few things.
Why can't we just use the chart from upstream repo if we're not changing it? |
It's not hosted anywhere and the way I wanted to work with it required it be hosted. If it's really a big deal, I can just host it myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 happy testing
…n the upstream chart: [email protected]:containous/traefik-helm-chart.git The chart isn't served by them so this is for us to start with. * fixed chart name Co-authored-by: Alejandro Escobar <[email protected]>
Copy in the upstream chart: [email protected]:containous/traefik-helm-chart.git
The chart isn't served by them so this is for us to start with.