Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump kommander ui #381

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Conversation

juliangieseke
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@juliangieseke juliangieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant comment on deleted binary files, but I dont think we should delete stable/opsportal/charts/kommander-0.2.7.tgz. opsportal is depending on it (for reasons I dont know) - #376 will clean that up, but for now we probably should keep it?

@@ -4,7 +4,7 @@ dependencies:
version: 0.1.4
- name: kommander-cluster-lifecycle
repository: https://mesosphere.github.io/kommander-cluster-lifecycle/charts
version: 0.3.4
version: v0.3.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: v0.3.5
version: 0.3.5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well that is what helm dependency update did :P
and it is correct https://github.com/mesosphere/kommander-cluster-lifecycle/releases

@juliangieseke juliangieseke marked this pull request as ready for review January 24, 2020 18:01
@juliangieseke juliangieseke requested a review from a team January 24, 2020 18:01
@sebbrandt87
Copy link
Contributor

sebbrandt87 commented Jan 24, 2020

Releases manual checked on a cluster.
Cloud provider in all aws combinations working! 8)

@natmegs
Copy link
Contributor

natmegs commented Jan 24, 2020

We tested and confirmed that we can provision aws clusters with both static credentials and roles-based credentials 👍

@GoelDeepak GoelDeepak changed the title chore: bump kommander/opsportal ui chore: bump kommander ui Jan 24, 2020
@juliangieseke juliangieseke merged commit 36ceabf into master Jan 25, 2020
@juliangieseke juliangieseke deleted the jgsb/kommander-bump-20200124 branch January 25, 2020 08:53
mesosphere-teamcity pushed a commit that referenced this pull request Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants