-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add kubefed fork #1036
chore: add kubefed fork #1036
Conversation
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
We can get kubernetes-retired/kubefed#1377 merged quickly (like tomorrow morning) I'm sure. Better than using a fork here imo. |
proxyURL: | ||
description: ProxyURL allows to set proxy URL for the cluster. | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is the reason we're adding fork of kubefed
chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will unblock https://jira.d2iq.com/browse/D2IQ-74314
@jimmidyson the upstream PR is against With merging this PR we'll get unblocked by temporarily using forked kubefed chart + custom built kubefed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this is only a temporary fork so I'll approve despite my CR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only pulled in for yakcl right? Just wondering if it's easier to pull the chart directly into the kommander-federation
local charts dir instead of using an extra m/charts fork, esp if this is just temporary
* chore: add kubefed fork Signed-off-by: Hector Fernandez <[email protected]> * chore: update test to exclude our own kubefed fork chart Signed-off-by: Hector Fernandez <[email protected]>
@gracedo I don't think we've considered this option. But you are right, this is temporary solution and the chart will be removed from our charts repo. |
Signed-off-by: Hector Fernandez [email protected]
What type of PR is this?
Chore
What this PR does/ why we need it:
While we are waiting to get kubernetes-retired/kubefed#1377 merged, we need to workaround that delay by getting our internal kubefed version based on v0.5.1.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist