Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubecost: Bump kubecost to v1.75.1 #1005

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Feb 25, 2021

What type of PR is this?

chore

What this PR does/ why we need it:

This fix was merged and released kubecost/cost-analyzer-helm-chart#773. Bumping kubecost to the latest version which includes the fix, and no need to disable PSP now

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-74182

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubecost: Enable PodSecurityPolicy

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@gracedo gracedo added the ready ready label Feb 25, 2021
@gracedo gracedo requested review from hectorj2f and a team February 25, 2021 03:48
@gracedo gracedo self-assigned this Feb 25, 2021
@gracedo gracedo force-pushed the gracedo/kubecost1750 branch from 057bc46 to e057741 Compare February 26, 2021 00:04
@@ -57,9 +57,6 @@ cost-analyzer:
enabled: true
# storageClass: "-"

podSecurityPolicy:
enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the default is true1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. True is the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not true1, but definitely true 😉

Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alejandroEsc alejandroEsc merged commit 88ccf83 into mesosphere:master Feb 26, 2021
d2iq-dispatch added a commit that referenced this pull request Feb 26, 2021
@gracedo gracedo deleted the gracedo/kubecost1750 branch February 26, 2021 19:46
@gracedo gracedo mentioned this pull request Feb 26, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants