Skip to content

Commit

Permalink
[nvidia] fix: use nindent correctly and correct values file (#370)
Browse files Browse the repository at this point in the history
* [nvidia] fix: use nindent correctly and ccorrect values file

* remove  tests
alejandroEsc authored Jan 20, 2020
1 parent 00c1e17 commit 060b51c
Showing 8 changed files with 28 additions and 70 deletions.
2 changes: 1 addition & 1 deletion staging/nvidia/Chart.yaml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ description: Nvidia GPU driver and device plugin for running Nvidia GPU
keywords:
- gpu
- nvidia
version: 0.3.0
version: 0.3.1
appVersion: "0.2.0"
home: http://github.com/mesosphere/charts/staging
sources:
Original file line number Diff line number Diff line change
@@ -12,17 +12,17 @@ spec:
labels:
name: {{ template "nvidia-dcgm-exporter.fullname" . }}
spec:
{{- if .Values.initContainers }}
initContainers:
{{- toYaml .Values.initContainers | nindent 8 }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | indent 8 }}
{{- toYaml .Values.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector:
{{- toYaml .Values.nodeSelector | indent 8 }}
{{- toYaml .Values.nodeSelector | nindent 8 }}
{{- end }}
{{- if .Values.initContainers }}
initContainers:
{{- toYaml .Values.initContainers | nindent 8 }}
{{- end }}
{{- if .Values.priorityClassName }}
priorityClassName: {{ .Values.priorityClassName }}
@@ -33,7 +33,7 @@ spec:
imagePullPolicy: {{ .Values.podNvidiaGpuMetricsExporter.image.pullPolicy }}
{{- if .Values.podNvidiaGpuMetricsExporter.resources }}
resources:
{{ toYaml .Values.podNvidiaGpuMetricsExporter.resources | indent 12 }}
{{- toYaml .Values.podNvidiaGpuMetricsExporter.resources | nindent 12 }}
{{- end }}
ports:
- name: gpu-metrics
@@ -54,7 +54,7 @@ spec:
imagePullPolicy: {{ .Values.nvidiaDcgmExporter.image.pullPolicy }}
{{- if .Values.nvidiaDcgmExporter.resources }}
resources:
{{- toYaml .Values.nvidiaDcgmExporter.resources | indent 12 }}
{{- toYaml .Values.nvidiaDcgmExporter.resources | nindent 12 }}
{{- end }}
securityContext:
runAsNonRoot: false

This file was deleted.

Original file line number Diff line number Diff line change
@@ -14,13 +14,17 @@ spec:
labels:
name: {{ template "nvidia-device-plugin.fullname" . }}
spec:
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector:
{{- toYaml .Values.nodeSelector | nindent 8 }}
{{- end }}
{{- if .Values.initContainers }}
initContainers:
{{- toYaml .Values.initContainers | nindent 8 }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | indent 8 }}
{{- end }}
priorityClassName: {{ .Values.priorityClassName }}
containers:
@@ -33,15 +37,11 @@ spec:
drop: ["ALL"]
{{- if .Values.resources }}
resources:
{{- toYaml .Values.resources | indent 12 }}
{{- toYaml .Values.resources | nindent 12 }}
{{- end }}
volumeMounts:
- name: device-plugin
mountPath: /var/lib/kubelet/device-plugins
{{- if .Values.nodeSelector }}
nodeSelector:
{{- toYaml .Values.nodeSelector | indent 8 }}
{{- end }}
volumes:
- name: device-plugin
hostPath:

This file was deleted.

12 changes: 6 additions & 6 deletions staging/nvidia/charts/nvidia-driver/templates/daemonset.yaml
Original file line number Diff line number Diff line change
@@ -12,17 +12,17 @@ spec:
labels:
name: {{ template "nvidia-driver.fullname" . }}
spec:
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector:
{{- toYaml .Values.nodeSelector | indent 8 }}
{{- toYaml .Values.nodeSelector | nindent 8 }}
{{- end }}
{{- if .Values.initContainers }}
initContainers:
{{- toYaml .Values.initContainers | nindent 8 }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | indent 8 }}
{{- end }}
priorityClassName: {{ .Values.priorityClassName }}
hostPID: true
@@ -35,7 +35,7 @@ spec:
privileged: true
{{- if .Values.resources }}
resources:
{{- toYaml .Values.resources | indent 12 }}
{{- toYaml .Values.resources | nindent 12 }}
{{- end }}
volumeMounts:
- name: update-driver

This file was deleted.

5 changes: 4 additions & 1 deletion staging/nvidia/values.yaml
Original file line number Diff line number Diff line change
@@ -3,7 +3,10 @@ grafana:

nvidia-dcgm-exporter:
enabled: true
resources: {}
podNvidiaGpuMetricsExporter:
resources: {}
nvidiaDcgmExporter:
resources: {}
nodeSelector: {}
tolerations: []
initContainers: []

0 comments on commit 060b51c

Please sign in to comment.