Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

konvoy-ui: don't attempt to create the CRD #132

Merged
merged 1 commit into from
Jul 19, 2019
Merged

konvoy-ui: don't attempt to create the CRD #132

merged 1 commit into from
Jul 19, 2019

Conversation

hectorj2f
Copy link
Contributor

related to: mesosphere/charts#53

@hectorj2f hectorj2f added the ready ready label Jul 19, 2019
@hectorj2f hectorj2f requested review from s12chung and jieyu July 19, 2019 16:10
@hectorj2f hectorj2f self-assigned this Jul 19, 2019
@s12chung
Copy link
Contributor

please move konvoy-ui to install after kommander, they're running in parallel: https://github.com/mesosphere/kubeaddons/blob/c6333b85d81a0eefe5a84444bd6fff93f99263e0/pkg/workflows/dependent_workflow.go#L36

@s12chung
Copy link
Contributor

otherwise, lgtm.

@hectorj2f
Copy link
Contributor Author

@s12chung what is the problem of installing them in parallel ? Please explain it to me

@s12chung
Copy link
Contributor

s12chung commented Jul 19, 2019 •
edited
Loading

konvoy-ui will try to create an instance of that CRD, so in a way, it's dependent on kommander. so they shouldn't be in parallel.

shaneutt
shaneutt reviewed Jul 19, 2019
View reviewed changes
Copy link
Collaborator

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍

But based on @s12chung's remarks it would appear that we have some unfinished business?

@hectorj2f
Copy link
Contributor Author

no, it is done here https://github.com/mesosphere/kubeaddons/pull/317

@hectorj2f hectorj2f merged commit eb3ccc3 into master Jul 19, 2019
@hectorj2f hectorj2f deleted the hectorj2f/crd_konvoy_ui branch July 19, 2019 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@joejulian joejulian joejulian approved these changes

@s12chung s12chung s12chung approved these changes

@jieyu jieyu Awaiting requested review from jieyu

Assignees

@hectorj2f hectorj2f

Labels
ready ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hectorj2f @s12chung @joejulian @shaneutt