Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil-cpp: update to 20230125.2 #996

Closed
wants to merge 1 commit into from

Conversation

v1993
Copy link
Contributor

@v1993 v1993 commented Apr 23, 2023

No description provided.

@v1993 v1993 force-pushed the abseil-cpp-upd1 branch from a0d967b to 232b58f Compare April 23, 2023 07:02
@neheb
Copy link
Collaborator

neheb commented Apr 23, 2023

Needs more work than a simple version bump. I’m trying to update protobuf but this package needs fixing first.

@v1993
Copy link
Contributor Author

v1993 commented Apr 23, 2023

It looks like (upstream) changes from previous version are trivial, though?

@neheb
Copy link
Collaborator

neheb commented Apr 23, 2023

#932 was incomplete is what I'm saying

@v1993
Copy link
Contributor Author

v1993 commented Apr 23, 2023

Makes sense. Sadly, I don't have a program at hand to test that it links/works right now. Nice that upstream has tests, though.

@neheb
Copy link
Collaborator

neheb commented Apr 23, 2023

My WIP branch for protobuf 3.22 was not pushed to github unfortunately. I won't be home for 2 months.

@neheb
Copy link
Collaborator

neheb commented Jul 1, 2023

@v1993
Copy link
Contributor Author

v1993 commented Jul 1, 2023

@neheb Should I just close this, then?

@neheb
Copy link
Collaborator

neheb commented Jul 1, 2023

nah just rebase

@inglor
Copy link
Contributor

inglor commented Jul 5, 2023

The current absl-wrap is not properly linking as others pointed out and I mentioned on my last PR (after merging). I didn't have time to look at it then and doubt I will have any time soon, but I can test with a program if we got a new version the wrap.

@bgilbert
Copy link
Contributor

Obsoleted by #1180 and #1624.

@neheb neheb closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants