Add SDL3 wrap. #1919
Open
Add SDL3 wrap. #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpakkane
force-pushed
the
sdl3
branch
5 times, most recently
from
86c6d90 to
00f2af8
Compare
Comment on lines
+198
to
+207
| foreach f : check_functions | ||
| if cc.has_function(f.get(1), prefix : f.get(2), dependencies: [sdl_deps]) | ||
| cdata.set(f.get(0), 1) | ||
| endif | ||
| endforeach |
There was a problem hiding this comment.
Early Windows failure since dl can be a Windows emulated one which we happen to provide in the wrapdb -- and thus has_function fails as it's forbidden to try to check an un-built subproject.
I suppose that isn't a general problem outside of the wrapdb CI... if https://github.com/dlfcn-win32/dlfcn-win32 isn't useful for SDL3 we can just use allow_fallback: false for it?
There was a problem hiding this comment.
It seems to work. I did not touch it at all, so 🤷 .
jpakkane
force-pushed
the
sdl3
branch
5 times, most recently
from
fd6c62b to
c4071a5
Compare
|
Can you also create wrap for SDL_image SDL_shadercross libs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is currently broken. It only does Linux. There is no configuration. It builds and links. It might work. I don't know as I did not test. Do not merge until it has at least Windows and macOS support.