Keep all build dirs inside the source tree.

[jpakkane]

VS and virus scanners complain when generating executables
in temporary directories.

[scivision]

Oops I meant to have #5547 show up here. It may be too much code change for now for this, it is just an example. This in #5546 is good too.

[nirbheek]

The cygwin failures in master are because of this PR. I bisected it down to this commit:

https://dev.azure.com/jussi0947/jussi/_build/results?buildId=3003

FAIL: test_install_umask (__main__.LinuxlikeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "run_unittests.py", line 4766, in test_install_umask
    (directory, want_mode, found_mode)))
AssertionError: 'drwxr-xr-x' != 'drwxrwxr-x'
- drwxr-xr-x
+ drwxrwxr-x
 : Expected directory usr to have mode drwxr-xr-x but found drwxrwxr-x instead.

...

FAIL: test_installed_modes_extended (__main__.LinuxlikeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "run_unittests.py", line 4709, in test_installed_modes_extended
    (fsobj, want_mode, found_mode)))
AssertionError: 'drwxr-x---' != 'drwxrwxr-x'
- drwxr-x---
+ drwxrwxr-x
 : Expected file bin to have mode drwxr-x--- but found drwxrwxr-x instead.

So somehow installing into the source tree messes up the umask code.

[nirbheek]

FWIW, we can't revert this either because that seems to break test_rc_depends_files on vs2019 vc2019x64vs:

FAIL: test_rc_depends_files (__main__.WindowsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "run_unittests.py", line 4044, in test_rc_depends_files
    self.assertBuildIsNoop()
  File "run_unittests.py", line 1416, in assertBuildIsNoop
    self.assertIn('Link:\n  All outputs are up-to-date.', ret)
AssertionError: 'Link:\n  All outputs are up-to-date.' not found in 'Microsoft (R) Build Engine version 16.1.76+g14b0a930a7 for .NET Framework\nCopyright (C) Microsoft Corporation. All rights reserved.\n\nBuilding the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.\nBuild started 7/9/2019 6:23:59 PM.\nProject "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" on node 1 (default targets).\nValidateSolutionConfiguration:\n  Building solution configuration "debug|x64".\nValidateProjects:\n  The project "RUN_TESTS" is not selected for building in solution configuration "debug|x64".\n  The project "RUN_INSTALL" is not selected for building in solution configuration "debug|x64".\nProject "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (1) is building "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@Windows resource for file \'res_myres.rc\'@cus.vcxproj" (2) on node 1 (default targets).\nProject "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@Windows resource for file \'res_myres.rc\'@cus.vcxproj" (2) is building "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\REGEN.vcxproj" (3) on node 1 (default targets).\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\REGEN.vcxproj]\nInitializeBuildStatus:\n  Creating "regen-temp\\REGEN.tlog\\unsuccessfulbuild" because "AlwaysCreate" was specified.\nCustomBuild:\n  All outputs are up-to-date.\nFinalizeBuildStatus:\n  Deleting file "regen-temp\\REGEN.tlog\\unsuccessfulbuild".\n  Touching "regen-temp\\REGEN.tlog\\REGEN.lastbuildstate".\nDone Building Project "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\REGEN.vcxproj" (default targets).\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@Windows resource for file \'res_myres.rc\'@cus.vcxproj]\nInitializeBuildStatus:\n  Creating "6eeb55f@@Windows resource for file \'res_myres.rc\'@cus\\Windows .78D7EDDD.tlog\\unsuccessfulbuild" because "AlwaysCreate" was specified.\nCustomBuild:\n  All outputs are up-to-date.\n  Performing Custom Build Tools\nFinalizeBuildStatus:\n  Deleting file "6eeb55f@@Windows resource for file \'res_myres.rc\'@cus\\Windows .78D7EDDD.tlog\\unsuccessfulbuild".\n  Touching "6eeb55f@@Windows resource for file \'res_myres.rc\'@cus\\Windows .78D7EDDD.tlog\\Windows resource for file \'res_myres.rc\'.lastbuildstate".\nDone Building Project "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@Windows resource for file \'res_myres.rc\'@cus.vcxproj" (default targets).\nProject "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (1) is building "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (4) on node 1 (default targets).\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\nInitializeBuildStatus:\n  Creating "6eeb55f@@reslib@sta\\reslib.tlog\\unsuccessfulbuild" because "AlwaysCreate" was specified.\nClCompile:\n  All outputs are up-to-date.\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(1445,5): warning MSB8012: TargetPath(C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\.\\libreslib.a) does not match the Library\'s OutputFile property value (C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\libreslib.a). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\nLib:\n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.21.27702\\bin\\HostX86\\x64\\Lib.exe /OUT:".\\libreslib.a" /NOLOGO /MACHINE:X64 "6eeb55f@@reslib@sta\\dummy.c.obj"\n  ..\\res\\res_myres.rc_myres.res\n  6eeb55f@@[email protected] -> C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\.\\libreslib.a\nFinalizeBuildStatus:\n  Deleting file "6eeb55f@@reslib@sta\\reslib.tlog\\unsuccessfulbuild".\n  Touching "6eeb55f@@reslib@sta\\reslib.tlog\\reslib.lastbuildstate".\nDone Building Project "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (default targets).\nProject "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (1) is building "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (5) on node 1 (default targets).\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\nInitializeBuildStatus:\n  Creating "6eeb55f@@shreslib@sha\\shreslib.tlog\\unsuccessfulbuild" because "AlwaysCreate" was specified.\nClCompile:\n  All outputs are up-to-date.\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(1264,5): warning MSB8012: TargetPath(C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\.\\shreslib.dll) does not match the Linker\'s OutputFile property value (C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\shreslib.dll). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Link.OutputFile). [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\nLink:\n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.21.27702\\bin\\HostX86\\x64\\link.exe /ERRORREPORT:QUEUE /OUT:".\\shreslib.dll" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level=\'asInvoker\' uiAccess=\'false\'" /manifest:embed /DEBUG:FULL /PDB:".\\shreslib.pdb" /SUBSYSTEM:WINDOWS /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"shreslib.lib" /MACHINE:X64 /DLL "6eeb55f@@shreslib@sha\\dummy.c.obj"\n  ..\\res\\res_myres.rc_myres.res\n  6eeb55f@@[email protected] -> C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\.\\shreslib.dll\nFinalizeBuildStatus:\n  Deleting file "6eeb55f@@shreslib@sha\\shreslib.tlog\\unsuccessfulbuild".\n  Touching "6eeb55f@@shreslib@sha\\shreslib.tlog\\shreslib.lastbuildstate".\nDone Building Project "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (default targets).\nProject "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (1) is building "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]" (6) on node 1 (default targets).\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]]\nInitializeBuildStatus:\n  Creating "prog@exe\\prog.tlog\\unsuccessfulbuild" because "AlwaysCreate" was specified.\nClCompile:\n  All outputs are up-to-date.\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(1264,5): warning MSB8012: TargetPath(C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\.\\prog.exe) does not match the Linker\'s OutputFile property value (C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\prog.exe). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Link.OutputFile). [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]]\nLink:\n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.21.27702\\bin\\HostX86\\x64\\link.exe /ERRORREPORT:QUEUE /OUT:".\\prog.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level=\'asInvoker\' uiAccess=\'false\'" /manifest:embed /DEBUG:FULL /PDB:".\\prog.pdb" /SUBSYSTEM:WINDOWS /TLBID:1 /ENTRY:"WinMainCRTStartup" /DYNAMICBASE /NXCOMPAT /IMPLIB:".\\prog.lib" /MACHINE:X64 "prog@exe\\prog.c.obj"\n  res\\res_myres.rc_myres.res\n  [email protected] -> C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\.\\prog.exe\nFinalizeBuildStatus:\n  Deleting file "prog@exe\\prog.tlog\\unsuccessfulbuild".\n  Touching "prog@exe\\prog.tlog\\prog.lastbuildstate".\nDone Building Project "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]" (default targets).\nDone Building Project "C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default targets).\n\nBuild succeeded.\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@Windows resource for file \'res_myres.rc\'@cus.vcxproj" (default target) (2) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\REGEN.vcxproj" (default target) (3) ->\n(PrepareForBuild target) -> \n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\REGEN.vcxproj]\n\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@Windows resource for file \'res_myres.rc\'@cus.vcxproj" (default target) (2) ->\n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@Windows resource for file \'res_myres.rc\'@cus.vcxproj]\n\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (default target) (4) ->\n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\n\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (default target) (4) ->\n(DoLibOutputFilesMatch target) -> \n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(1445,5): warning MSB8012: TargetPath(C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\.\\libreslib.a) does not match the Library\'s OutputFile property value (C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\libreslib.a). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\n\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (default target) (5) ->\n(PrepareForBuild target) -> \n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\n\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]" (default target) (5) ->\n(DoLinkOutputFilesMatch target) -> \n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(1264,5): warning MSB8012: TargetPath(C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\.\\shreslib.dll) does not match the Linker\'s OutputFile property value (C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\shreslib.dll). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Link.OutputFile). [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\res\\6eeb55f@@[email protected]]\n\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]" (default target) (6) ->\n(PrepareForBuild target) -> \n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(460,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]]\n\n\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\winmain.sln" (default target) (1) ->\n"C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]" (default target) (6) ->\n(DoLinkOutputFilesMatch target) -> \n  C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\MSBuild\\Microsoft\\VC\\v160\\Microsoft.CppBuild.targets(1264,5): warning MSB8012: TargetPath(C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\.\\prog.exe) does not match the Linker\'s OutputFile property value (C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\prog.exe). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Link.OutputFile). [C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpxqcc3jv_\\[email protected]]\n\n    8 Warning(s)\n    0 Error(s)\n\nTime Elapsed 00:00:01.58\n'