Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention add_dist_script in meson dist docs #14186

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

omoerbeek
Copy link
Contributor

@eli-schwartz
Copy link
Member

――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
"GNOME Builder" https://gitlab.gnome.org/GNOME/gnome-builder 500
"GNOME Web" https://gitlab.gnome.org/GNOME/epiphany 500
"Nautilus" https://gitlab.gnome.org/GNOME/nautilus 500
"Pango" https://git.gnome.org/browse/pango/ 500
"Sysprof" https://git.gnome.org/browse/sysprof 500
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――


Summary of Failures:

2/2 validate_links FAIL            4.84s   exit status 1

lol... unsure how this could be reliably detected/avoided.


Modification to the checked out files like generating files or
setting version info can be done by dist scripts.
Make a script run during `meson dist` with this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in combination with the above suggestion, remove "this"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually maybe remove the line entirely.

Modification to the checked out files like generating files or
setting version info can be done with dist scripts:
```meson
[[#meson.add_dist_script]]('distscript.sh')
```

@jsoref
Copy link
Contributor

jsoref commented Jan 27, 2025

Link checkers should not treat 5xx errors as failures. Only 4xx responses are user failures worth failing over.

@eli-schwartz
Copy link
Member

On the one hand, yes. On the other hand, let's say an upstream site goes "out of business", their backend database gets unplugged one day, and the whole domain simply returns http 500 for the next 5 years because it's still being served by nginx on a box that is also doing something totally different and not website related.

I've definitely seen a few sites like that. It's arguably a broken link, albeit much less common.

@jsoref
Copy link
Contributor

jsoref commented Jan 27, 2025

Oh, it's fine to warn for that, I'm just opposed to error-ing for it.

@jpakkane
Copy link
Member

Please keep the commits squashed down to one. Extraneous commits like "better phrasing" are just noise in the commit history.

@eli-schwartz
Copy link
Member

^^ what he said

In theory I could squash this locally, update your PR (you have left "maintainers are allowed to edit this pull request" enabled) and then merge the result, but it would have to wait until I get back to my laptop...

@jpakkane jpakkane merged commit d25fcbb into mesonbuild:master Jan 29, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants