-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention add_dist_script in meson dist docs #14186
Mention add_dist_script in meson dist docs #14186
Conversation
lol... unsure how this could be reliably detected/avoided. |
docs/markdown/Creating-releases.md
Outdated
|
||
Modification to the checked out files like generating files or | ||
setting version info can be done by dist scripts. | ||
Make a script run during `meson dist` with this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in combination with the above suggestion, remove "this"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or actually maybe remove the line entirely.
Modification to the checked out files like generating files or
setting version info can be done with dist scripts:
```meson
[[#meson.add_dist_script]]('distscript.sh')
```
Link checkers should not treat 5xx errors as failures. Only 4xx responses are user failures worth failing over. |
On the one hand, yes. On the other hand, let's say an upstream site goes "out of business", their backend database gets unplugged one day, and the whole domain simply returns http 500 for the next 5 years because it's still being served by nginx on a box that is also doing something totally different and not website related. I've definitely seen a few sites like that. It's arguably a broken link, albeit much less common. |
Oh, it's fine to warn for that, I'm just opposed to error-ing for it. |
Co-authored-by: Josh Soref <[email protected]>
Please keep the commits squashed down to one. Extraneous commits like "better phrasing" are just noise in the commit history. |
^^ what he said In theory I could squash this locally, update your PR (you have left "maintainers are allowed to edit this pull request" enabled) and then merge the result, but it would have to wait until I get back to my laptop... |
See PowerDNS/pdns#15048