vs2010backend: Initial MASM language support #14171
Conversation
mochaaP
force-pushed
the
vs-backend-masm
branch
2 times, most recently
from
4ff01c4 to
999e500
Compare
|
cc @neheb you might have interest testing this :) |
mochaaP
force-pushed
the
vs-backend-masm
branch
from
999e500 to
8208528
Compare
| @@ -656,6 +657,13 @@ def create_basic_project(self, target_name, *, | |||
| # "The build tools for v142 (Platform Toolset = 'v142') cannot be found. ... please install v142 build tools." | |||
| # This is extremely unhelpful and misleading since the v14x build tools ARE installed. | |||
| ET.SubElement(root, 'Import', Project=r'$(VCTargetsPath)\Microsoft.Cpp.props') | |||
| ext_settings_grp = ET.SubElement(root, 'ImportGroup', Label='ExtensionSettings') | |||
There was a problem hiding this comment.
Wouldn't it better to add this node only if masm_type?
There was a problem hiding this comment.
I kept this in case we potentially need further BuildCustomizations, or make vs find where to properly add the element if you tick that build customization box in the GUI.
mesonbuild/backend/vs2010backend.py
Outdated
| @@ -691,7 +699,8 @@ def create_basic_project(self, target_name, *, | |||
| if target_ext: | |||
| ET.SubElement(direlem, 'TargetExt').text = target_ext | |||
|
|
|||
| ET.SubElement(direlem, 'EmbedManifest').text = 'false' | |||
| # Fix weird mt.exe error | |||
There was a problem hiding this comment.
What weird error? I think it would be better to remove this comment, and to fix the next line in a separate commit explaining what it is fixing.
There was a problem hiding this comment.
mt.exe is trying to compile a non-existent .generated.manifest file and link it with the target if this element exists. This does not happen without masm props.
| @@ -1782,6 +1817,9 @@ def path_normalize_add(path, lis): | |||
| ET.SubElement(inc_objs, 'Object', Include=s) | |||
|
|
|||
| ET.SubElement(root, 'Import', Project=r'$(VCTargetsPath)\Microsoft.Cpp.targets') | |||
| ext_tgt_grp = ET.SubElement(root, 'ImportGroup', Label='ExtensionTargets') | |||
There was a problem hiding this comment.
I think that element could be created only if masm
mochaaP
force-pushed
the
vs-backend-masm
branch
from
8208528 to
cf6874e
Compare
Fix #11653
xrefs: libffi/libffi#746