-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip broken tests in CI #13518
base: master
Are you sure you want to change the base?
Skip broken tests in CI #13518
Conversation
@@ -1,4 +1,5 @@ | |||
{ | |||
"expect_skip_on_jobname": ["opensuse", "ubuntu-rolling"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the name: "expect_skip".
Not "skip". This doesn't skip tests, it asserts in CI that if they are skipped, it doesn't constitute "UNEXPECTEDSKIP" status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI has finished collecting the os_comp jobs now -- this PR causes 7 jobs to fail. e.g
[UNEXRUN] frameworks: 17 mpi (method=auto)
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-ubuntu-rolling-clang'
[UNEXRUN] frameworks: 17 mpi (method=config-tool)
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-ubuntu-rolling-clang'
[UNEXRUN] frameworks: 17 mpi (method=pkg-config)
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-ubuntu-rolling-clang'
[UNEXRUN] frameworks: 24 libgcrypt
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-arch-gcc'
Both fixed by #12143
Why are the symbols invalid?
Fixed on July 25 by me, but I had grouped it in with another PR since it needs an image builder run. |
👍 Was marked as a draft so didn't catch that.
Because Ubuntu has
👍 |
It would be fantastic if someone could investigate whether Ubuntu needs to change or meson's tests need to change, and get that resolved... |
Skips 4 tests in total, these are preventing the CI Image Builder workflow to run.