Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip broken tests in CI #13518

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RossComputerGuy
Copy link
Contributor

@RossComputerGuy RossComputerGuy commented Aug 6, 2024

Skips 4 tests in total, these are preventing the CI Image Builder workflow to run.

  • failing: 80 dub library: version of dub is incompatible on OpenSUSE and Ubuntu
  • failing: 81 dub executable: version of dub is incompatible on OpenSUSE and Ubuntu
  • frameworks: 17 mpi: gfortran tries to use invalid symbols on Ubuntu
  • frameworks: 24 libgcrypt: libgcrypt-config does not exist on Arch Linux due to the move to pkg-config

@@ -1,4 +1,5 @@
{
"expect_skip_on_jobname": ["opensuse", "ubuntu-rolling"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the name: "expect_skip".

Not "skip". This doesn't skip tests, it asserts in CI that if they are skipped, it doesn't constitute "UNEXPECTEDSKIP" status.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI has finished collecting the os_comp jobs now -- this PR causes 7 jobs to fail. e.g

 [UNEXRUN]   frameworks: 17 mpi    (method=auto)
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-ubuntu-rolling-clang'
 [UNEXRUN]   frameworks: 17 mpi    (method=config-tool)
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-ubuntu-rolling-clang'
 [UNEXRUN]   frameworks: 17 mpi    (method=pkg-config)
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-ubuntu-rolling-clang'
 [UNEXRUN]   frameworks: 24 libgcrypt
Reason: Test ran, but was expected to be skipped for MESON_CI_JOBNAME 'linux-arch-gcc'

@eli-schwartz
Copy link
Member

  • failing: 80 dub library: version of dub is incompatible on OpenSUSE and Ubuntu

  • failing: 81 dub executable: version of dub is incompatible on OpenSUSE and Ubuntu

Both fixed by #12143

  • frameworks: 17 mpi: gfortran tries to use invalid symbols on Ubuntu

Why are the symbols invalid?

  • frameworks: 24 libgcrypt: libgcrypt-config does not exist on Arch Linux due to the move to pkg-config

Fixed on July 25 by me, but I had grouped it in with another PR since it needs an image builder run.

@RossComputerGuy
Copy link
Contributor Author

Both fixed by #12143

👍 Was marked as a draft so didn't catch that.

Why are the symbols invalid?

Because Ubuntu has MPI_Init and not mpi_ini_, gfortran tries linking to the latter.

Fixed on July 25 by me, but I had grouped it in with another PR since it needs an image builder run.

👍

@eli-schwartz
Copy link
Member

Because Ubuntu has MPI_Init and not mpi_ini_, gfortran tries linking to the latter.

It would be fantastic if someone could investigate whether Ubuntu needs to change or meson's tests need to change, and get that resolved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants