Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting b_vscrt via meson setup --reconfigure has no effect on the generated build.ninja #11732

Closed
dnicolodi opened this issue Apr 25, 2023 · 1 comment · Fixed by #12697
Closed

Setting b_vscrt via meson setup --reconfigure has no effect on the generated build.ninja #11732

dnicolodi opened this issue Apr 25, 2023 · 1 comment · Fixed by #12697

Comments

@dnicolodi
Copy link
Member

dnicolodi commented Apr 25, 2023 •
edited
Loading

Reconfiguring with a different value of b_vscrt does not result in changes to build.ninja.

Running meson setup with -Db_vscrt=mdd results in the correct flag being passed to the compiler:

$ meson setup build --vsenv -Db_vscrt=mdd
...
  User defined options
    vsenv        : True
    b_vscrt      : mdd
...
$ grep '/MD' build/build.ninja
 ARGS = ... "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/std:c11" "/O2" "/Zi" ...
...

edited to remove unrelated output. However, reconfiguring with -Db_vscrt=md has no effect:

$ meson setup build --vsenv -Db_vscrt=md --reconfigure
...
  User defined options
    vsenv        : True
    b_vscrt      : md
...
$ grep '/MD' build/build.ninja
 ARGS = ... "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/std:c11" "/O2" "/Zi" ...
...

also edited to remove unrelated output. I would have expected the /MDd flag to be turned into /MD.

This is Windows with VS 17.5.3, Python 3.10, meson 1.1.0 and ninja 1.10.2.
@max8rr8 max8rr8 mentioned this issue Oct 22, 2023
Open
bruchar1 added a commit to bruchar1/meson that referenced this issue Dec 1, 2023
@bruchar1
Remove get_buildtype_args function
fa73e91 
This is a first step to make `buildtype` a true alias of `debug` and
`optimization` options.

See mesonbuild#10808.

Relates to:
- mesonbuild#11645
- mesonbuild#12096
- mesonbuild#5920
- mesonbuild#5814
- mesonbuild#8220
- mesonbuild#8493
- mesonbuild#9540
- mesonbuild#10487
- mesonbuild#12265
- mesonbuild#8308
- mesonbuild#8214
- mesonbuild#7194
- mesonbuild#11732
@bruchar1 bruchar1 mentioned this issue Dec 1, 2023
Merged
bruchar1 added a commit to bruchar1/meson that referenced this issue Dec 2, 2023
@bruchar1
Remove get_buildtype_args function
a982b66 
This is a first step to make `buildtype` a true alias of `debug` and
`optimization` options.

See mesonbuild#10808.

Relates to:
- mesonbuild#11645
- mesonbuild#12096
- mesonbuild#5920
- mesonbuild#5814
- mesonbuild#8220
- mesonbuild#8493
- mesonbuild#9540
- mesonbuild#10487
- mesonbuild#12265
- mesonbuild#8308
- mesonbuild#8214
- mesonbuild#7194
- mesonbuild#11732
bruchar1 added a commit to bruchar1/meson that referenced this issue Dec 5, 2023
@bruchar1
Remove get_buildtype_args function
677e04d 
This is a first step to make `buildtype` a true alias of `debug` and
`optimization` options.

See mesonbuild#10808.

Relates to:
- mesonbuild#11645
- mesonbuild#12096
- mesonbuild#5920
- mesonbuild#5814
- mesonbuild#8220
- mesonbuild#8493
- mesonbuild#9540
- mesonbuild#10487
- mesonbuild#12265
- mesonbuild#8308
- mesonbuild#8214
- mesonbuild#7194
- mesonbuild#11732
jpakkane pushed a commit that referenced this issue Dec 23, 2023
@bruchar1 @jpakkane
Remove get_buildtype_args function
4761e4c 
This is a first step to make `buildtype` a true alias of `debug` and
`optimization` options.

See #10808.

Relates to:
- #11645
- #12096
- #5920
- #5814
- #8220
- #8493
- #9540
- #10487
- #12265
- #8308
- #8214
- #7194
- #11732
@bruchar1
Copy link
Member

bruchar1 commented Jan 3, 2024

This seems to be true for all base options. For instance, b_ndebug faces the same problem.

bruchar1 added a commit to bruchar1/meson that referenced this issue Jan 4, 2024
@bruchar1
Fix base options not reconfigurable
cb61c1f 
Fixes mesonbuild#11732
bruchar1 added a commit to bruchar1/meson that referenced this issue Jan 4, 2024
@bruchar1
Fix base options not reconfigurable
9f26903 
Fixes mesonbuild#11732
@bruchar1 bruchar1 mentioned this issue Jan 4, 2024
Merged
bruchar1 added a commit to bruchar1/meson that referenced this issue Jan 4, 2024
@bruchar1
Fix base options not reconfigurable
98db3e7 
Fixes mesonbuild#11732
dcbaker pushed a commit that referenced this issue Feb 23, 2024
@bruchar1 @dcbaker
Fix base options not reconfigurable
20c9f3e 
Fixes #11732
soumyaDghosh pushed a commit to soumyaDghosh/meson that referenced this issue Jun 4, 2024
@bruchar1 @soumyaDghosh
Fix base options not reconfigurable
2096919 
Fixes mesonbuild#11732
gerioldman pushed a commit to gerioldman/meson that referenced this issue Jul 2, 2024
@bruchar1 @gerioldman
Remove get_buildtype_args function
6f40300 
This is a first step to make `buildtype` a true alias of `debug` and
`optimization` options.

See mesonbuild#10808.

Relates to:
- mesonbuild#11645
- mesonbuild#12096
- mesonbuild#5920
- mesonbuild#5814
- mesonbuild#8220
- mesonbuild#8493
- mesonbuild#9540
- mesonbuild#10487
- mesonbuild#12265
- mesonbuild#8308
- mesonbuild#8214
- mesonbuild#7194
- mesonbuild#11732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix base options not reconfigurable bruchar1/meson
2 participants
@dnicolodi @bruchar1