Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle rpath for dependency across sub-directories #509

Closed
metab0t opened this issue Oct 4, 2023 · 0 comments · Fixed by #510
Closed

Handle rpath for dependency across sub-directories #509

metab0t opened this issue Oct 4, 2023 · 0 comments · Fixed by #510

Comments

@metab0t
Copy link
Contributor

metab0t commented Oct 4, 2023 •
edited
Loading

If a project has two directories: dirA and dirB

meson.build

_link_to = []

subdir('dirA')
_linkto += libA

subdir('dirB')

dirB\meson.build

meson.build

py = import('python').find_installation()
py.extension_module(
    'libB',
    'libB.c',
    link_with: _linkto,
    install: true,
)

Then the libB.so will have rpath=['$ORIGIN/../dirA'], which cannot be fixed by current mechanism (only applicable to $ORIGIN/)

meson-python/mesonpy/_rpath.py

Line 30 in 36e8205

if '$ORIGIN/' in rpath:

Sample folder:
link-against-local-lib.tar.gz
@metab0t metab0t mentioned this issue Oct 4, 2023
Merged
metab0t added a commit to metab0t/meson-python that referenced this issue Oct 4, 2023
@metab0t
BUG: fix all RPATHs that start with $ORIGIN
bf2f0f7 
Some library may contain RPATH like '$ORIGIN/../src' and should be fixed as well
Fixes: mesonbuild#509
metab0t added a commit to metab0t/meson-python that referenced this issue Oct 4, 2023
@metab0t
BUG: fix all RPATHs that start with $ORIGIN
98d3544 
Some library may contain RPATH like '$ORIGIN/../src' and should be fixed as well
Fixes: mesonbuild#509
dnicolodi pushed a commit to metab0t/meson-python that referenced this issue Oct 4, 2023
@metab0t @dnicolodi
BUG: fix all RPATHs that start with $ORIGIN
bb91a3c 
When shared libraries are build in a project subdir or in a
subproject, the RAPTH added by meson pointing to the shared library
build directory is not just '$ORIGIN/' but a longer relative path.

Apply the same fix to all RPATHs that start with '$ORING/'.

Fixes mesonbuild#509.
dnicolodi pushed a commit to metab0t/meson-python that referenced this issue Oct 4, 2023
@metab0t @dnicolodi
BUG: fix all RPATHs that start with $ORIGIN
4cb00a1 
When shared libraries are build in a project subdir or in a
subproject, the RAPTH added by meson pointing to the shared library
build directory is not just '$ORIGIN/' but a longer relative path.

Apply the same fix to all RPATHs that start with '$ORING/'.

Fixes mesonbuild#509.
dnicolodi pushed a commit that referenced this issue Oct 5, 2023
@metab0t @dnicolodi
BUG: fix all RPATHs that start with $ORIGIN
edf8ba2 
When shared libraries are build in a project subdir or in a
subproject, the RAPTH added by meson pointing to the shared library
build directory is not just '$ORIGIN/' but a longer relative path.

Apply the same fix to all RPATHs that start with '$ORING/'.

Fixes #509.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: fix all RPATHs that start with $ORIGIN metab0t/meson-python
1 participant
@metab0t