Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up and unify CI workflows #39

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Clean-up and unify CI workflows #39

merged 1 commit into from
Feb 4, 2025

Conversation

krant
Copy link
Contributor

@krant krant commented Feb 2, 2025

Opinionated maintenance pass over CI:

  • Unify "Testing" and "Hygiene" workflows. It gives single environment per OS and declutters Actions UI.
  • Upgrade to ubuntu-latest runner.
  • Remove actions/cache altogether. It was not working anyway (Cache not found on each CI run) and it makes little sense for projects without Cargo.lock.
  • Fix cache by using properly set-up Swatinem/rust-cache@v2
  • Remove dtolnay/rust-toolchain - Github runners are already have latest stable Rust.
  • Remove pnpm setup - I have not found why it's needed, tests are passing without it.
  • Simpler wording for less UI noise (Testing Suite -> Testing, unit-test -> test, etc.).
  • CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse is enabled by default already.

We will need more features from CI in the near future - let's build them on top of minimal and clean YAML.

.github/workflows/testing.yml Show resolved Hide resolved
@lukipuki lukipuki merged commit 798f193 into meshtastic:main Feb 4, 2025
3 checks passed
@krant krant deleted the ci branch February 4, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants