Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bunch of deps not requiring code change #37

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

krant
Copy link
Contributor

@krant krant commented Feb 1, 2025

No description provided.

Copy link
Collaborator

@lukipuki lukipuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised this didn't change Cargo.lock, we were already using these versions.

@krant
Copy link
Contributor Author

krant commented Feb 1, 2025

@lukipuki sorry, messed up with the rebase, now it's good

@lukipuki lukipuki merged commit b2d26a4 into meshtastic:main Feb 1, 2025
6 checks passed
@krant krant deleted the update_deps branch February 1, 2025 14:25
@krant
Copy link
Contributor Author

krant commented Feb 1, 2025

I was surprised this didn't change Cargo.lock, we were already using these versions.

Probably because those were SemVer compatible. I wonder if it makes sense to relax version requirements, by dropping PATCH or even MINOR parts of some packages versions? That should make it easier for cargo to unify versions in projects with many overlapping dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants