Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:slack button url #230

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

Nayhay99
Copy link
Contributor

@Nayhay99 Nayhay99 commented Dec 2, 2024

Notes for Reviewers

This PR fixes opening intended slack URL on button click.

  • Replaced the button href prop with url prop
  • Removed the styling of <a> tag inside join-community section as
    • it over-rid the button style by adding a yellowish background to the button which should have teal background color only
    • No other <a> tag present inside the section, hence I think styling it was unnecessary.
    • To maintain consistency, <Button/> component should be used along with url prop and the styling should be applied on the button instead of <a> tag.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Nayonika  Mohapatra <[email protected]>
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 9efbed1
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/674e0e1911ec3400083b206d
😎 Deploy Preview https://deploy-preview-230--meshery-play.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nayhay99
Copy link
Contributor Author

Nayhay99 commented Dec 2, 2024

Request your review @leecalcote

@Nayhay99
Copy link
Contributor Author

Nayhay99 commented Dec 2, 2024

#229

@Nayhay99
Copy link
Contributor Author

Nayhay99 commented Dec 4, 2024

@leecalcote Were you able to review the PR?

@leecalcote
Copy link
Member

@Nayhay99, if you get a chance to join the weekly Meshery Dev meetings, I highly encourage you to jump in ---> https://meshery.io/calendar

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. ✅ Thank you for your diligence in how you identified the bug, proposed a fix, and implemented it, @Nayhay99. 🥇

@leecalcote leecalcote merged commit 36070ed into meshery:master Dec 4, 2024
2 checks passed
@Nayhay99
Copy link
Contributor Author

Nayhay99 commented Dec 4, 2024

@Nayhay99, if you get a chance to join the weekly Meshery Dev meetings, I highly encourage you to jump in ---> https://meshery.io/calendar

Sure! Will join. Thank you

@Nayhay99
Copy link
Contributor Author

Nayhay99 commented Dec 4, 2024

These changes look great. ✅ Thank you for your diligence in how you identified the bug, proposed a fix, and implemented it, @Nayhay99. 🥇

Looking forward to contribute and learn more. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants