-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:slack button url #230
fix:slack button url #230
Conversation
Signed-off-by: Nayonika Mohapatra <[email protected]>
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Request your review @leecalcote |
@leecalcote Were you able to review the PR? |
@Nayhay99, if you get a chance to join the weekly Meshery Dev meetings, I highly encourage you to jump in ---> https://meshery.io/calendar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great. ✅ Thank you for your diligence in how you identified the bug, proposed a fix, and implemented it, @Nayhay99. 🥇
Sure! Will join. Thank you |
Looking forward to contribute and learn more. Thank you! |
Notes for Reviewers
This PR fixes opening intended slack URL on button click.
<a>
tag insidejoin-community
section as<a>
tag present inside the section, hence I think styling it was unnecessary.<Button/>
component should be used along withurl
prop and the styling should be applied on the button instead of<a>
tag.Signed commits