Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the x logo in the footer #161

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

captain-Akshay
Copy link
Contributor

Notes for Reviewers

This PR fixes #138
added new feature of using svg components rather than img which is mostly voided
made the icon exactly like the icon in meshery.io

  • creates a new issue of changing all img element to svg component for better element render and control over the icons.
Screencast.from.2023-10-02.21-10-14.webm

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit ca3c982
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/651ae4a233c5950009f19363
😎 Deploy Preview https://deploy-preview-161--meshery-play.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@captain-Akshay
Copy link
Contributor Author

@thisiskaransgit check it once and would love to hear some review and feedback!

Copy link

stale bot commented Nov 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 11, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Nov 12, 2023
Copy link

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote leecalcote merged commit 619ba5a into meshery:master Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing to new Twitter X Logo
3 participants