Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Automatic Graphql Docs Generation #2989

Merged
merged 8 commits into from
May 24, 2021

Conversation

dhruv0000
Copy link
Member

@dhruv0000 dhruv0000 commented May 21, 2021

Signed-off-by: dhruv0000 [email protected]

Description
This PR automatically generates GraphQL docs based on the schema in internal/graphql/schema/schema.graphql and creates an custom .md page which the Jekyll Site can refer to.

Generate Docs using

make install
bundle exec rake graphql:compile_docs

Watch the generated docs at extensibility/graphql-reference endpoint. (temporary)

DONE:

  • Add doc generation capability for:
    • query
    • mutations
    • Object Type
    • Enumeration types
    • Scalar types
    • Input types
    • Abstract types (Commented for future use)
  • Add doc generation capability for:
    • subscriptions
  • Add description for each Object in schema.graphql
  • Fix the subsection hierarchy
  • Update the Meshery Server/UI be compatible with the new (minor changes to follow certain GraphQL practices) schema

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented May 21, 2021

Deploy Preview for meshery-docs ready!

Built with commit b1326d8

https://deploy-preview-2989--meshery-docs.netlify.app

@dhruv0000
Copy link
Member Author

@dhruv0000 dhruv0000 added the pr/do-not-merge PRs not ready to be merged label May 21, 2021
@dhruv0000 dhruv0000 changed the title Automatic Graphql Docs Generation [Docs] Automatic Graphql Docs Generation May 21, 2021
@leecalcote
Copy link
Member

This is a great looking docs preview.

@leecalcote leecalcote added component/api Issues related to API area/docs Documentation update needed labels May 21, 2021
@dhruv0000 dhruv0000 requested review from leecalcote and kumarabd May 23, 2021 23:55
@@ -1,6 +1,55 @@
GEM
remote: https://rubygems.org/
specs:
actioncable (6.0.3.7)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope GitHub Pages supports these. 🤞

@dhruv0000
Copy link
Member Author

A review on the GraphQL comments in internal/graphql/schema/schema.graphql itself would me much helpful @leecalcote .

Signed-off-by: dhruv0000 <[email protected]>
kumarabd
kumarabd previously approved these changes May 24, 2021
Copy link
Contributor

@kumarabd kumarabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarabd kumarabd marked this pull request as ready for review May 24, 2021 10:04
@kumarabd
Copy link
Contributor

@dhruv0000 remove do-not-merge once ready, we'll merge then

Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000 dhruv0000 removed the pr/do-not-merge PRs not ready to be merged label May 24, 2021
@dhruv0000
Copy link
Member Author

Ready for a Merge @abhishekkumkar 👍

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how GH Pages does with this...

Thank you, @dhruv0000!

@leecalcote leecalcote merged commit 5e2b86a into meshery:master May 24, 2021
@dhruv0000
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/api Issues related to API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants