Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Add tests for model import command #13177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AdiAkhileshSingh15
Copy link

Summary of changes
This PR refactors certain functionalities into helper utils, adds tests for helper functions (to manage the utility function tests separately from the import command tests), and tests for import command. So far, I've added test scenarios for handling invalid files and empty files, as implemented by @lekaf974 in PR #12328. For additional testing, if someone could provide guidance on specific tests we need to include, I’d be happy to contribute further!

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: AdiAkhileshSingh15 <[email protected]>
Copy link

welcome bot commented Jan 8, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

@vishalvivekm
Copy link
Contributor

@AdiAkhileshSingh15 Thank you for your contributions! Let's discuss this today, during Meshery Development call at 9:00 AM CT | 8:30 PM IST. Adding it as an agenda item to the meeting minutes || meeting link.

Signed-off-by: AdiAkhileshSingh15 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] Create Unit and Integration Tests for mesheryctl model import Command
2 participants