-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mesheryctl] Create Unit and Integration Tests for mesheryctl model import
Command
#12137
Comments
This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.
|
Hi @leecalcote, I'd like to contribute to this issue. Could you please assign it to me? |
Hi, I'd like to take on this issue. I have experience with unit testing in Python and some with Go. I've been going through the project since the newcomer's meeting and feel confident I can do this. Please assign it to me! Thanks! |
mesheryctl model import
Commandmesheryctl model import
Command
@Jash2606 still interested ? |
I can take this work! |
@prachinandi I have already started to work on this one |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
what's the progress on this issue? is someone onto it? |
@AdiAkhileshSingh15 my PR was opened for a while and lot of changes were made so I closed the PR. It can be yours if you want |
sure @lekaf974! thanks. |
Description
We need to develop comprehensive unit and integration tests for the
mesheryctl model import
command. This command handles importing models from both individual files and directories, compressing the data if necessary, and sending it to the Meshery server for processing.The goal is to ensure that the
import model
command functions as expected, handles errors appropriately, and interacts with the Meshery server correctly.Current Behavior
Currently, there are no automated tests for the
mesheryctl model import
command, which imports models in various formats such as.yaml
,.json
,.tar.gz
, and.zip
from files and directories. The command checks the input, compresses directories, and sends the data to the Meshery API for model registration.Desired Behavior
Tests should cover the following aspects:
File and Directory Handling:
.yaml
,.json
).API Interaction:
/api/meshmodels/register
is properly called and responds correctly.Error Handling:
Resources
mesheryctl/internal/cli/root/model/import.go
Contributor Resources
The text was updated successfully, but these errors were encountered: