Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used required attribute in the input fields of Newsletter form #655

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Used required attribute in the input fields of Newsletter form #655

merged 1 commit into from
Jan 10, 2022

Conversation

MukulKolpe
Copy link
Contributor

Description

This PR fixes #653

Notes for Reviewers
Used required attribute in the input fields of Newsletter form so that form should not proceed without all required inputs.

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Jan 5, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Jan 5, 2022 •
edited
Loading

✔️ Deploy Preview for mesheryio-preview ready!

🔨 Explore the source changes: 189d294

🔍 Inspect the deploy log: https://app.netlify.com/sites/mesheryio-preview/deploys/61d7597b88ded600082f68a2

😎 Browse the preview: https://deploy-preview-655--mesheryio-preview.netlify.app

@YashKamboj
Copy link
Contributor

@MukulKolpe not working

@YashKamboj
Copy link
Contributor

@MukulKolpe you can check layer5io/getnighthawk#234 for reference

@YashKamboj
Copy link
Contributor

@MukulKolpe it is still redirecting.

@MukulKolpe
Copy link
Contributor Author

yes...I'm trying to figure out the reason. Do you see any obvious issues in the code?

@MukulKolpe
Copy link
Contributor Author

@YashKamboj It should work now...

@YashKamboj
Copy link
Contributor

@MukulKolpe It is working but the css is changed

@MukulKolpe
Copy link
Contributor Author

@YashKamboj can you please review this...

warunicorn19
warunicorn19 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, Thank you @MukulKolpe

@warunicorn19 warunicorn19 merged commit 7bd1286 into meshery:master Jan 10, 2022
@welcome
Copy link

welcome bot commented Jan 10, 2022

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        ⭐ Please leave a star on the project. 😄

@MukulKolpe
Copy link
Contributor Author

Thank you @YashKamboj and @warunicorn19 ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashKamboj YashKamboj YashKamboj approved these changes

@warunicorn19 warunicorn19 warunicorn19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need validation for the Newsletter form
3 participants
@MukulKolpe @YashKamboj @warunicorn19