Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Update: Enhance Meshery.io Catalog #2039

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

FaheemOnHub
Copy link

@FaheemOnHub FaheemOnHub commented Feb 4, 2025

Description:
This PR introduces several improvements to the Meshery catalog:

  • Added a new landing page that categorizes items separately.
  • Implemented filters for each category, maintaining the functionality of the current view.
  • Extended filter support to models.
  • Linked designs to the models used for their creation, visible in the design’s metadata.

Images:
Screenshot 2025-02-11 at 12 45 24 PM
Screenshot 2025-02-11 at 12 52 54 PM
Screenshot 2025-02-11 at 12 53 10 PM

Signed commits

  • Yes, I signed my commits.

Signed-off-by: TheFaheem <[email protected]>
Copy link

welcome bot commented Feb 4, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 787e3f1
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/67ac9a5fe674d9000815d2c6
😎 Deploy Preview https://deploy-preview-2039--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gemfile Outdated Show resolved Hide resolved
@FaheemOnHub FaheemOnHub added the pr/do-not-merge PRs not ready to be merged label Feb 9, 2025
@vishalvivekm
Copy link
Contributor

@FaheemOnHub

Let's discuss this on websites call on Monday at 6:30 PM IST (7:00 AM CT). Add it as an agenda item to the meeting minutes, if you would :)

@FaheemOnHub FaheemOnHub changed the title UI Update: Catalog Page Redesign (in Progress) UI Update: Enhance Meshery.io Catalog Feb 11, 2025
@FaheemOnHub FaheemOnHub added area/catalog and removed pr/do-not-merge PRs not ready to be merged labels Feb 11, 2025
@vishalvivekm
Copy link
Contributor

@FaheemOnHub
It would be great if you could revert the lint, whitespace changes

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FaheemOnHub
Instead of having exact same styling and js code logic duplicated thrice for designs, filters, models, can we not have them at one place and then reuse ?

@FaheemOnHub
Copy link
Author

@FaheemOnHub Instead of having exact same styling and js code logic duplicated thrice for designs, filters, models, can we not have them at one place and then reuse ?

got it , will be placing all under one file

Signed-off-by: TheFaheem <[email protected]>
@FaheemOnHub
Copy link
Author

@FaheemOnHub Instead of having exact same styling and js code logic duplicated thrice for designs, filters, models, can we not have them at one place and then reuse ?

All the duplicate js code and styles are placed under one file. Kindly merge

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove formatting and whitespace changes, not pertinent to the issue.

Signed-off-by: TheFaheem <[email protected]>
Signed-off-by: TheFaheem <[email protected]>
Signed-off-by: TheFaheem <[email protected]>
@FaheemOnHub FaheemOnHub mentioned this pull request Feb 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants