Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #362 Switch to the new Docker Github action in Meshery-maesh repo #14

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Fixed #362 Switch to the new Docker Github action in Meshery-maesh repo #14

merged 1 commit into from
Oct 17, 2019

Conversation

ashiscs
Copy link
Contributor

@ashiscs ashiscs commented Oct 13, 2019 •
edited by leecalcote
Loading

@leecalcote leecalcote added the kind/chore Necessary task label Oct 13, 2019
@ashiscs ashiscs changed the title correctly updated entire docker block in meshery-maesh repo from mesh… Fixed #362 Switch to the new Docker Github action in Meshery-maesh repo Oct 13, 2019
@ashiscs ashiscs mentioned this pull request Oct 13, 2019
Closed
@ashiscs
Copy link
Contributor Author

ashiscs commented Oct 13, 2019

Fixed #14

@leecalcote
Copy link
Member

@girishranganathan would you like to review given your familiarity here?

leecalcote
leecalcote approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck, I'll jump in. LGTM.

@leecalcote leecalcote merged commit a849a14 into master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@girishranganathan girishranganathan Awaiting requested review from girishranganathan

Assignees

@girishranganathan girishranganathan

Labels
kind/chore Necessary task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to the new Docker Github action in Meshery-maesh repo
3 participants
@ashiscs @leecalcote @girishranganathan