Issue#222 : Updated images and references for Meshery logo #232
Conversation
Added Meshery Welcome Light and Dark Images. Signed-off-by: Ahmad Shehanshah <[email protected]>
Deleted layer5 celebration image after uploading new welcome images Signed-off-by: Ahmad Shehanshah <[email protected]>
Replaced  with the correct reference to the code for images uploaded Signed-off-by: Ahmad Shehanshah <[email protected]>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
Co-authored-by: Karan Thakur <[email protected]> Signed-off-by: Ahmad Shehanshah <[email protected]>
Sourced and Updated Images from the original repo. Signed-off-by: Ahmad Shehanshah <[email protected]>
Signed-off-by: Ahmad Shehanshah <[email protected]>
Signed-off-by: Ahmad Shehanshah <[email protected]>
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery-nginx-sm/master/.github/welcome/Meshery-celebration-Dark.svg"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery-nginx-sm/master/.github/welcome/Meshery-celebration-Light.svg"> | ||
| <img alt="Shows a black logo in light color mode and a white one in dark color mode."> |
There was a problem hiding this comment.
Please add a src="https://raw.githubusercontent.com/meshery/meshery-nginx-sm/master/.github/welcome/Meshery-celebration-Dark.svg" attribute here. This helps in adding a fallback image for browsers that do not support conditional rendering.
There was a problem hiding this comment.
This change needs to be done in the <img> tag here.
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery-nginx-sm/master/.github/welcome/Meshery-celebration-Dark.svg"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery-nginx-sm/master/.github/welcome/Meshery-celebration-Light.svg"> |
There was a problem hiding this comment.
Interchange the dark and light with appropriate srcsets. The image with white text should be on a dark scheme, and vice versa.
Description
This PR fixes #222
This PR updates the images and references in the repository to use the Meshery logo instead of the Layer5 logo. It also adds conditional rendering based on the user's selected theme. The following changes have been made:
I replaced the previous logo with the Meshery-celebration-Light and Meshery-celebration-Dark images. element in the .github/config.yml file to use the appropriate image sources for light and dark themes.Modified the firstPRMergeComment section in the config.yml file to display the new image using the element.
Updated the
Notes for Reviewers
Please review the changes made to update the images and references in the repository. Ensure the new images are correctly displayed based on the user's selected theme. Test the changes locally and verify that they are functioning as expected.
I have followed the contribution conventions as mentioned in the community guidelines:
I have included a descriptive title for this PR, starting with [].
I built and tested the changes before submitting this PR.
I have signed my commits.
Thank you for reviewing my contribution. I would greatly appreciate your feedback and guidance.
Signed commits