v2 nginx adapter #19
Merged
v2 nginx adapter #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kumarabd <[email protected]>
Signed-off-by: kumarabd <[email protected]>
| st := status.Installing | ||
|
|
||
| if del { | ||
| st = status.Removing | ||
| } | ||
|
|
||
| for _, template := range templates { | ||
| contents, err := utils.ReadRemoteFile(string(template)) | ||
| contents, err := readFileSource(string(template)) |
There was a problem hiding this comment.
@kumarabd I think we have this function in meshkit now 😅
There was a problem hiding this comment.
Oh that's great then, kill change them
| } | ||
|
|
||
| fmt.Println("Done") | ||
| return path.Join(configRootPath, "nginx-meshctl"), nil | ||
| return nil | ||
| } | ||
|
|
||
| func downloadBinary(platform string) (*http.Response, error) { |
There was a problem hiding this comment.
downloadBinary was actually failing after a few days I created #17 . I believe the reason for that is that the urls have changed now. Can we instead place the binaries manually?
There was a problem hiding this comment.
@Utkarsh-pro the binary is already in place. this is just for in-case scenarios.
1 task
leecalcote
reviewed
Dec 21, 2020
Signed-off-by: kumarabd <[email protected]>
leecalcote
approved these changes
Dec 24, 2020
Signed-off-by: kumarabd <[email protected]>
Signed-off-by: kumarabd <[email protected]>
Signed-off-by: kumarabd <[email protected]>
leecalcote
approved these changes
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kumarabd [email protected]
Description
This PR fixes #
Notes for Reviewers
Signed commits