Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CI channels for nginx-sm #12

Merged
merged 2 commits into from
Oct 30, 2020
Merged

feat: add CI channels for nginx-sm #12

merged 2 commits into from
Oct 30, 2020

Conversation

kushthedude
Copy link
Contributor

Signed-off-by: Kush Trivedi [email protected]

@welcome
Copy link

welcome bot commented Oct 30, 2020

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@kushthedude
add build and releaser
16f0129 
Signed-off-by: Kush Trivedi <[email protected]>
@kushthedude kushthedude added the area/ci Continuous integration | Build and release label Oct 30, 2020
leecalcote
leecalcote approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@leecalcote leecalcote merged commit 88ca5ba into master Oct 30, 2020
@welcome
Copy link

welcome bot commented Oct 30, 2020

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@kushthedude kushthedude deleted the ci branch October 30, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@kumarabd kumarabd Awaiting requested review from kumarabd

Assignees
No one assigned
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kushthedude @leecalcote