Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated figma links in issue template #528

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: updated figma links in issue template #528

merged 1 commit into from
Jul 13, 2023

Conversation

Yana-Gupta
Copy link
Member

@Yana-Gupta Yana-Gupta commented Jul 12, 2023

Description

This PR fixes #527

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Jul 12, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@github-actions
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check above.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄 on the project.

@Yana-Gupta
Copy link
Member Author

@leecalcote Can you review this pr once.

@leecalcote leecalcote requested review from thisiskaransgit and removed request for leecalcote, Aisuko and Revolyssup July 13, 2023 14:20
@Yana-Gupta
Copy link
Member Author

@thisiskaransgit Can you review it once.

Copy link

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yana-Gupta Thank you for this fix, kindly resolve the DCO check and we're good to go

@Yana-Gupta
Copy link
Member Author

@thisiskaransgit DCO resolve done

Copy link

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yana-Gupta Looks good to merge, thank you for your contribution 🎉

@Yana-Gupta
Copy link
Member Author

@thisiskaransgit if everything is good, then we should merge this pr?

@thisiskaransgit
Copy link

thisiskaransgit commented Jul 13, 2023

@Yana-Gupta, rest assured, any of the maintainers will review it again and hit the merge button.

@leecalcote leecalcote merged commit d32b710 into meshery:master Jul 13, 2023
@welcome
Copy link

welcome bot commented Jul 13, 2023

Thanks for your contribution to the Meshery community! 🎉

Shows a black logo in light color mode and a white one in dark color mode.
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Template Updates for Figma link
3 participants