-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated figma links in issue template #528
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check above. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
@leecalcote Can you review this pr once. |
@thisiskaransgit Can you review it once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yana-Gupta Thank you for this fix, kindly resolve the DCO check and we're good to go
Signed-off-by: Yana Gupta <[email protected]>
@thisiskaransgit DCO resolve done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yana-Gupta Looks good to merge, thank you for your contribution 🎉
@thisiskaransgit if everything is good, then we should merge this pr? |
@Yana-Gupta, rest assured, any of the maintainers will review it again and hit the merge button. |
Thanks for your contribution to the Meshery community! 🎉
|
Description
This PR fixes #527
Notes for Reviewers
Signed commits