Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add operations_test.go w/signoff #504

Merged
merged 1 commit into from
May 2, 2023

Conversation

khareyash05
Copy link
Contributor

Description

This PR fixes #501

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@khareyash05 khareyash05 mentioned this pull request May 2, 2023
1 task
@Aisuko Aisuko self-requested a review May 2, 2023 07:02
@Aisuko Aisuko self-assigned this May 2, 2023
@Aisuko
Copy link
Member

Aisuko commented May 2, 2023

Also, the golangci-lint CI is failed but it may need more PRs to fix these issues.

Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aisuko Aisuko merged commit e80ee27 into meshery:master May 2, 2023
@welcome
Copy link

welcome bot commented May 2, 2023

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

@Aisuko
Copy link
Member

Aisuko commented May 2, 2023

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unit tests for operations.go
2 participants