Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error descriptions #252

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Conversation

dhruv0000
Copy link
Member

Signed-off-by: dhruv0000 [email protected]

Description

This PR adds descriptions for the errors.

Notes for Reviewers
Still struggling with the tone of the error descriptions. Suggestions/comments for better descriptions are welcome.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000 dhruv0000 requested review from leecalcote and kumarabd July 22, 2021 11:48
Signed-off-by: dhruv0000 <[email protected]>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit 7f1b8a3 into meshery:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants