Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filters for dynamic component generation and upgraded meshkit version #203

Merged
merged 3 commits into from
Oct 10, 2021

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Oct 10, 2021

Description

The function in this PR will be replaced by gitwalker function when that gets added to meshkit. It was taking too long for that function to be available in meshkit and we want dynamic component generation to work, so I made the PR

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@leecalcote
Copy link
Member

I checked earlier today and didn't see an open PR on MeshKit. I don't see anything previously committed that hasn't been released either.

@leecalcote leecalcote merged commit de85e2c into meshery:master Oct 10, 2021
@DelusionalOptimist
Copy link
Contributor

@Revolyssup 😅 😠

time="2021-10-12T13:56:50Z" level=info msg="KUBECONFIG: /home/appuser/.meshery/kubeconfig.yaml" app=consul-adapter
time="2021-10-12T13:56:50Z" level=info msg="Registering static workloads..." app=consul-adapter
time="2021-10-12T13:56:50Z" level=info msg="Adaptor Listening at port: 10002" app=consul-adapter
panic: interface conversion: error is *os.PathError, not *errors.Error

goroutine 20 [running]:
github.com/layer5io/meshkit/errors.GetCode(0x2d84000, 0xc000b93e00, 0x22, 0x0)
        /go/pkg/mod/github.com/layer5io/[email protected]/errors/errors.go:90 +0xd1
github.com/layer5io/meshkit/logger.(*Logger).Error(0xc000115738, 0x2d84000, 0xc000b93e00)
        /go/pkg/mod/github.com/layer5io/[email protected]/logger/logger.go:57 +0xaa
main.registerCapabilities(0xc000118bf4, 0x5, 0x2de85a0, 0xc000115738)
        /github.com/layer5io/meshery-consul/main.go:113 +0x230
created by main.main
        /github.com/layer5io/meshery-consul/main.go:92 +0x72b

@DelusionalOptimist
Copy link
Contributor

Mentioning this in the docs was good but I realized we can prevent these all together if meshkit handles this gracefully.
Opened up meshery/meshkit#119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants