Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity of error messages in ErrCreatingComponents #165

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

devhindo
Copy link
Member

so the current error logging contains configuration.URL, incorrect.Version, configuration.Make and correct.Make looking like some sort of an object like this:
image

so I thought about adding some spaces in the error message for clarity to look like this:
image

If this is a desired behavior let me know so I can update other errors in the same way, If not, this pr should be closed

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit 006f015 into meshery:master Dec 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants