Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kanvas.yml to generate snapshot #88

Closed

Conversation

Aijeyomah
Copy link
Contributor

Notes for Reviewers

This PR fixes #

  • Fixed kanvas.yaml to accept the correct inputs.
  • Changed workflowAccessToken to use secrets.GITHUB_TOKEN.
  • Updated ldflags for local builds.
  • Tweaked the payload needed for generating snapshots.

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (e85764d) to head (15c68d1).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cmd/kanvas-snapshot/cmd.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #88   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           4       4           
  Lines         219     221    +2     
======================================
- Misses        219     221    +2     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aijeyomah Aijeyomah force-pushed the fix-kanvas-snapshot-workflow branch from e6f7890 to feaa5f3 Compare January 16, 2025 01:03
@Aijeyomah Aijeyomah force-pushed the fix-kanvas-snapshot-workflow branch from 16b2c28 to ed341c2 Compare January 16, 2025 01:23
@Aijeyomah Aijeyomah closed this Jan 16, 2025
@Aijeyomah Aijeyomah deleted the fix-kanvas-snapshot-workflow branch January 16, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant