update payload to generate snapshot #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aijeyomah
force-pushed
the
update-snapshot-payload
branch
from
50fa5af to
9f8fd99
Compare
Aijeyomah
force-pushed
the
update-snapshot-payload
branch
from
5015029 to
f9cb5ce
Compare
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Aijeyomah
force-pushed
the
update-snapshot-payload
branch
from
731f8fb to
d7f6ee3
Compare
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
leecalcote
reviewed
Oct 8, 2024
leecalcote
reviewed
Oct 8, 2024
leecalcote
reviewed
Oct 8, 2024
| ErrGeneratingSnapshotCode = "kanvas-snapshot-902" | ||
| ErrHTTPPostRequestCode = "kanvas-snapshot-903" | ||
| ErrDecodingAPICode = "kanvas-snapshot-905" | ||
| ErrUnexpectedResponseCodeCode = "kanvas-snapshot-906" |
There was a problem hiding this comment.
Will you enhance the ErrInvalidChartURI message to be more specific about filesystem and/or URL references?
leecalcote
reviewed
Oct 8, 2024
| ErrHTTPPostRequestCode = "kanvas-snapshot-1003" | ||
| ErrDecodingAPICode = "kanvas-snapshot-1004" | ||
| ErrRequiredFieldNotProvidedCode = "kanvas-snapshot-1005" | ||
| ErrInvalidChartURICode = "kanvas-snapshot-900" |
There was a problem hiding this comment.
ErrCreatingMesheryDesign - offers little insight as to what happened (why the chart wasn't converted to design) and what to do about it or where to go for help.
leecalcote
reviewed
Oct 8, 2024
| @@ -1,16 +1,18 @@ | |||
| package errors | |||
|
|
|||
| import ( | |||
| "fmt" | |||
|
|
|||
| "github.com/layer5io/meshkit/errors" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
ErrHTTPPostRequest - the message isn't overly accurate or helpful. It would seem that the most likely cause of this failure is
- User's network connectivity. Can they reach the currently configured remote provider?
- The currently configured remote provider is unavailable / down.
- Network connectivity is fine, but their request was malformed. Are they missing a required parameter (an email address) or did they provide an invalid email address?
- Network connectivity is fine, but they authentication failed.
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
leecalcote
reviewed
Oct 8, 2024
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
|
@Aijeyomah I was expecting to see some movement on this PR today. I’m going to merge now. I’ll ask that you address the outstanding comments on both this and @MUzairS15's PR. |
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
mesheryctl. Will add test for knavas-snapshot in another PRSigned commits