Merge pull request #86 from Aijeyomah/update-name-flag

remove 'n' from the name flag

.golangci.yml

@@ -14,4 +14,12 @@ linters:
 
 linters-settings:
   gofmt:
-    simplify: true
+    simplify: true
+issues:
+  exclude-dirs:
+    - '.*pkg/mod.*'
+    - '.*go/.*'
+    - '.*Cellar.*'             # Skip Homebrew Go installation directory
+    - '.*libexec.*'
+  exclude-files:
+    - '.*toolchain@.*'

Makefile

@@ -96,7 +96,7 @@ print_home:
 
 
 local.deploy: local.build ## Deploys locally built Helm plugin
-  @rm -rf ${HOME}/Library/helm/plugins/helm-kanvas-snapshot/bin/helm-kanvas-snapshot
+	@rm -rf ${HOME}/Library/helm/plugins/helm-kanvas-snapshot/bin/helm-kanvas-snapshot
 	@cp helm-images ${HOME}/Library/helm/plugins/helm-kanvas-snapshot/bin/helm-kanvas-snapshot
 
 

README.md

@@ -72,19 +72,19 @@ To install the Meshery Snapshot Helm Plugin, use the following steps:
 Once the plugin is installed, you can generate a snapshot using either a packaged or unpackaged Helm chart.
 
 ```bash
-helm helm-kanvas-snapshot -f <chart-URI> [-n <snapshot-name>] [-e <email>]
+helm helm-kanvas-snapshot -f <chart-URI> [--name <snapshot-name>] [-e <email>]
 ```
 
 - **`-f`**, **`--file`**: (required) path or URL to the Helm chart (required).
-- **`-n`**, **`--name`**: (optional) name for the snapshot. If not provided, a name will be auto-generated based on the chart name.
+- **`--name`**: (optional) name for the snapshot. If not provided, a name will be auto-generated based on the chart name.
 - **`-e`, **`--email`**: (optional) email address to notify when snapshot is ready. If not provided, a link to the snapshot will be displayed in the terminal.
 
 **Example**
 
 To generate a snapshot for a Helm chart located at `https://meshery.io/charts/v0.8.0-meshery.tar.gz`, you can use:
 
 ```bash
-helm helm-kanvas-snapshot -f https://meshery.io/charts/v0.8.0-meshery.tar.gz -n meshery-chart
+helm helm-kanvas-snapshot -f https://meshery.io/charts/v0.8.0-meshery.tar.gz --name meshery-chart
 ```
 
 ## Contributing
@@ -128,7 +128,7 @@ helm plugin install kanvas-snapshot
 Once the plugin is built, you can test it locally. For example, to generate a snapshot for a Helm chart, run the following command:
 
 ```bash
-helm helm-kanvas-snapshot -f https://meshery.io/charts/v0.8.0-meshery.tar.gz -n meshery-chart
+helm helm-kanvas-snapshot -f https://meshery.io/charts/v0.8.0-meshery.tar.gz --name meshery-chart
 ```
 
 This command will trigger the snapshot generation process. If everything is set up correctly, you should see a visual snapshot URL or receive the snapshot via email, depending on the options you specified.

cmd/kanvas-snapshot/cmd.go

@@ -43,12 +43,12 @@ var generateKanvasSnapshotCmd = &cobra.Command{
 
 		Example usage:
 
-		helm kanvas-snapshot -n nginx-helm -f https://meshery.github.io/meshery.io/charts/meshery-v0.7.109.tgz -e [email protected]
+		helm kanvas-snapshot -f https://meshery.github.io/meshery.io/charts/meshery-v0.7.109.tgz -e [email protected] --name nginx-helm
 
 		Flags:
-		-f, --file string	URI to Helm chart (required)
-		-n, --name string	(optional name for the Meshery design
+		-f, --file  string	URI to Helm chart (required)
 		-e, --email string	email address to notify when snapshot is ready (required)
+		    --name  string	(optional) name for the Meshery design
 		-h			Help for Helm Kanvas Snapshot plugin`,
 
 	RunE: func(_ *cobra.Command, _ []string) error {
@@ -66,9 +66,8 @@ var generateKanvasSnapshotCmd = &cobra.Command{
 			handleError(errors.ErrCreatingMesheryDesign(err))
 		}
 
-		assetLocation := fmt.Sprintf("https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/%s.png", designID)
+		assetLocation := fmt.Sprintf("https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/helm-plugin-assets/%s.png", designID)
 
-		// Generate Snapshot
 		err = GenerateSnapshot(designID, assetLocation, WorkflowAccessToken)
 		if err != nil {
 			handleError(errors.ErrGeneratingSnapshot(err))
@@ -243,14 +242,16 @@ func Main(providerToken, mesheryCloudAPIBaseURL, mesheryAPIBaseURL, workflowAcce
 	MesheryAPIBaseURL = mesheryAPIBaseURL
 	WorkflowAccessToken = workflowAccessToken
 	generateKanvasSnapshotCmd.Flags().StringVarP(&chartURI, "file", "f", "", "URI to Helm chart (required)")
-	generateKanvasSnapshotCmd.Flags().StringVarP(&designName, "design-name", "n", "", "Optional name for the Meshery design")
+	generateKanvasSnapshotCmd.Flags().StringVar(&designName, "name", "", "Optional name for the Meshery design")
 	generateKanvasSnapshotCmd.Flags().StringVarP(&email, "email", "e", "", "Optional email to associate with the Meshery design")
 
 	_ = generateKanvasSnapshotCmd.MarkFlagRequired("file")
 
 	if err := generateKanvasSnapshotCmd.Execute(); err != nil {
-		Log.Error(err)
-		os.Exit(1)
+		errors.ErrHTTPPostRequest(err)
+		generateKanvasSnapshotCmd.SetFlagErrorFunc(func(cmd *cobra.Command, err error) error {
+			return nil
+		})
 	}
 }
 

go.mod

@@ -1,6 +1,7 @@
 module github.com/meshery/helm-kanvas-snapshot
 
-go 1.21.8
+go 1.23
+
 toolchain go1.23.4
 
 require (