Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for markdown-style links #6158

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ryanwjackson
Copy link

@ryanwjackson ryanwjackson commented Dec 29, 2024

📑 Summary

Add support for markdown-style links on line messages and notes

Resolves #1279

📏 Design Decisions

This currently only affects line messages and notes on sequence diagrams

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 29, 2024

🦋 Changeset detected

Latest commit: c69c21d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Enhancement New feature or request label Dec 29, 2024
Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit c69c21d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6772cb5647b1ad0008ca940d
😎 Deploy Preview https://deploy-preview-6158--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 29, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6158
npm i https://pkg.pr.new/mermaid-js/mermaid@6158
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6158
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6158

commit: c69c21d

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 10.86957% with 82 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (df636c6) to head (c69c21d).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/sequence/svgDraw.js 0.00% 78 Missing ⚠️
packages/mermaid/src/diagrams/sequence/styles.js 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6158      +/-   ##
==========================================
+ Coverage     4.48%   4.49%   +0.01%     
==========================================
  Files          383     383              
  Lines        54038   54125      +87     
  Branches       596     596              
==========================================
+ Hits          2425    2435      +10     
- Misses       51613   51690      +77     
Flag Coverage Δ
unit 4.49% <10.86%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/common/common.ts 54.21% <100.00%> (+1.20%) ⬆️
packages/mermaid/src/diagrams/sequence/styles.js 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/sequence/svgDraw.js 0.00% <0.00%> (ø)

@ryanwjackson ryanwjackson marked this pull request as ready for review December 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sequenceDiagram Links
1 participant