-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 5747 replace $root with relative paths #5838
fix 5747 replace $root with relative paths #5838
Conversation
🦋 Changeset detectedLatest commit: 1951a0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Thanks! |
📑 Summary
$root
with more verbose (but portable) relative path (e.g.../../foo.js
)pnpm test:check:tsc
which builds the tarballs and uses them in a minimal TypeScript projectResolves #5747.
Alternative to #5805.
📏 Design Decisions
Mostly see discussion on above-linked items.
vs #5805:
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.