fix: Add support for ~test Array~string~ back in Class

[sidharthv96]

📑 Summary

Add back support for ~test Array~string~

Context: #4534 (comment)

📏 Design Decisions

We cannot remove that support as it would be a breaking change.

Also, if ~test Int is supported, ~test Array~string~ should be too.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.

[codecov]

Codecov Report

Merging #4805 (4944694) into develop (69b4b48) will increase coverage by 29.91%.
The diff coverage is 28.57%.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #4805       +/-   ##
============================================
+ Coverage    45.34%   75.26%   +29.91%     
============================================
  Files           53      146       +93     
  Lines         6669    14504     +7835     
  Branches        32      614      +582     
============================================
+ Hits          3024    10916     +7892     
+ Misses        3644     3462      -182     
- Partials         1      126      +125     

Flag	Coverage Δ
e2e	81.68% <41.66%> (?)
unit	45.25% <9.52%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
packages/mermaid/src/diagrams/common/common.ts	68.02% <28.57%> (+12.47%)	⬆️

... and 141 files with indirect coverage changes

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	4944694
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/64f42e606adf8300079dda4b
😎 Deploy Preview	https://deploy-preview-4805--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Yokozuna59]

I think the PR title is misleading. Originally, I thought we're adding ~ also as a possible keyword to class name. But it appears you're just re-add the ability to have ~ (package) as a visibility when we have generic class.

[aloisklink]

It's awesome to fix a breaking change, but I'm struggling to see what the breaking change this PR fixes actually is.

What is ~test Array~string~? Can you give an example of a Mermaid diagram that has it (maybe also showing a screenshot, if the diagram only worked in an very old version of Mermaid)?

It would also be helpful if you could point to when support for ~test Array~string~ was broken (ideally to a specific commit or PR).

[sidharthv96]

@aloisklink this PR was actually targeted at #4534

The test case was removed in that PR.

Context: #4534 (comment)

[knsv]

Looks good! Some small thing in the review but I see now show stoppers!

[aloisklink]

@aloisklink this PR was actually targeted at #4534

The test case was removed in that PR.

Context: #4534 (comment)

Ahh, awesome! 👍 Great catch on getting it fixed while it was still in the develop branch.

Btw, is it worth labeling this PR with Skip changelog? Since this bug has never been released to users (it's just on the develop branch), there's less of a need to put it in the Release notes (maybe current users of ~test Array~string~ might get confused if they see this PR in the release notes).

[jgreywolf]

Im not sure where my comment went - but this was by design. any leading ~ characters are stripped before the string is even sent to this method