Directive support for many diagrams, config bugfix #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue in journey svgDraw.drawText expected an attribute (textMargin) but did not receive one and raised an error: <tspan> attribute x: Expected length, "NaN". Added parseDirective to journeyDb
…agram-v2 for class diagrams)
…urityLevel='loose' must be set by the siteConfig. The default securityLevel as of now is 'strict'. This causes html to be url encoded.
Added the parser as the first argument to parseDirective to support custom directive handling (for now delegated within mermaidAPI but should probably discriminate based on type for delegation)
Diagrams now properly reset to siteConfig when there are multiple diagrams on a single page
Fixed a regression bug I introduced in theme.spec.js
Ensured tests pass
Added directive support to pie (Refactored pie parsing to be a bit more clear) Added more unit tests to pie
…s-in-actor-names-in-sequence-diagrams' into develop
cmmoran
changed the title
3 tasks
Fixed an issue with markerUnits: (default is 'strokeWidth' not 0
GraphObjects.md: [ and ] should be escaped in text (they're links otherwise) flow.jison: fixed a parsing issue when the direction is omitted (defaults to 'TB') stateRenderer-v2: was silently failing due to a try/catch in the parse function. (intentional?) removed to show errorHandler mermaidAPI: removed unnecessary call to updateRendererConfigs since reinitialize does this
Fixed a class diagram parsing issue
knsv
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Directive support for most diagrams
Slight pie refactor
Added pie unit tests
Fixed a config issue where multiple diagrams on the same page (using the same mermaid context) would inadvertently share the same configuration if the first config utilized the
initdirective to set configuration variables.📏 Design Decisions
The jison parsing statements for directive support are fairly drop-in and require very little change on the parser. These changes have been added and the modifications to the parserDb support file have been made for the following diagrams:
The remaining one(s) to update are: