Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1562 arrowheads in edges to cluster #1563

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Jul 21, 2020

📑 Summary

Resolves an edge case. Sometimes when calculating the intersection point of an edge to a cluster the edge the intersection by chance is already in the list of points. When thats the case don't add it.

Resolves #1562

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jul 21, 2020
@knsv knsv merged commit 835a3f6 into develop Jul 21, 2020
@knsv knsv deleted the bug/1562_arrowheads_in_edges_to_cluster branch July 5, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrowhead sometimes points in the wrong direction in beta of flowcharts
1 participant