-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add security level antiscript option, use rich html format but dont permit script element. #1471
add security level antiscript option, use rich html format but dont permit script element. #1471
Conversation
Hi @vantoan8x, I like where you are going with this PR. But I wonder if we should cover the use case Adding tests for the new settings would be awesome, you can find the tests here:
|
Dear @GDFaber, I will cover test case and add another option "allow only links for click events" for this tommorow in vietname time GMT+7, this now late in my side. Regards. |
Sure, take your time for it, there's no need to rush :-) |
@vantoan8x Hi, any updates on this one? |
Dear Knut,
I am so busy,
but I arrange to complete it at this weekend, is it ok?
Thanks and Regards.
β¦On Wed, Jul 1, 2020 at 1:39 AM Knut Sveidqvist ***@***.***> wrote:
@vantoan8x <https://github.com/vantoan8x> Hi, any updates on this one?
β
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1471 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHIXDURYQHMZAY64PBDLM3RZIWNTANCNFSM4N5LTQZA>
.
--
Contact to :
------------------------------------------------------------
Nguyα»
n VΔn ToΓ n
Tel : 0908543369.
Email : [email protected]
|
β¦ remove all script element.
308498f
to
fce2a16
Compare
Dear @knsv, I added test case for this function. Regards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a good middle ground that will be appreciated by some sites integrating mermaid. Also I appreciate you adding the test.
Resolves #1376 |
β¦ remove all script element.
π Summary
Brief description about the content of your PR.
Resolves #
π Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
π Tasks
Make sure you
develop
branch