Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression issue: ER diagrams is ignoring themes #3831

Closed
knsv opened this issue Nov 21, 2022 · 0 comments · Fixed by #3837
Closed

Regression issue: ER diagrams is ignoring themes #3831

knsv opened this issue Nov 21, 2022 · 0 comments · Fixed by #3837
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@knsv
Copy link
Collaborator

knsv commented Nov 21, 2022

Description

Regression issue: ER diagrams is ignoring themes. The cypress image comparison test fails as the er diagrams ignores the theme settings.

Steps to reproduce

Run the cypress tests theme.spec.js and look at the er diagrams.

Screenshots

image

Code Sample

No response

Setup

Desktop

  • OS and Version: [Windows, Linux, Mac, ...]
  • Browser and Version: [Chrome, Edge, Firefox]

Smartphone

  • Device: [Samsung, iPhone, ...]
  • OS and Version: [Android, iOS, ...]
  • Browser and Version: [Chrome, Safari, ...]

Additional Context

No response
@knsv knsv added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Nov 21, 2022
knsv added a commit that referenced this issue Nov 21, 2022
@knsv
#3831 Re-enabling themes for er diagrams
f9222a3
@knsv knsv mentioned this issue Nov 21, 2022
Merged
3 tasks
pbrolin47 added a commit that referenced this issue Nov 21, 2022
@pbrolin47
Merge pull request #3837 from mermaid-js/3831_er_theme
96d7666 
#3831 Re-enabling themes for er diagrams
sidharthv96 added a commit that referenced this issue Nov 22, 2022
@sidharthv96
Merge branch 'develop' into sidv/optimizeSize
9da29da 
* develop: (21 commits)
  chore: docs:build
  chore: docs:build
  tiny fix and change: "The/y cannot" -> "Cannot..."
  remove 'horz' from  cSpell.json
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove 'horz' from  cSpell.json
  Revert "Added pie"
  chore: Fix cSpell in pieRenderer
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove console stmt
  #3831 Re-enabling themes for er diagrams
  #3835 Adding path to list of elements to be styled
  #3882 fix for issues with mindmaps  with only a single node
  Integrations added - Visual Studio Code [Polyglot Interactive Notebooks]
  Fix typos
  #3778 Adding a hexgon shape
  ...
sidharthv96 added a commit that referenced this issue Nov 23, 2022
@sidharthv96
Merge branch 'develop' into sidv/mermaidDocs
ab81b50 
* develop: (79 commits)
  chore: docs:build
  chore: docs:build
  tiny fix and change: "The/y cannot" -> "Cannot..."
  remove 'horz' from  cSpell.json
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove 'horz' from  cSpell.json
  Revert "Added pie"
  chore: Fix cSpell in pieRenderer
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove console stmt
  #3831 Re-enabling themes for er diagrams
  #3835 Adding path to list of elements to be styled
  #3882 fix for issues with mindmaps  with only a single node
  chore(deps): update pnpm to v7.17.0
  docs: Remove warning in readme
  chore(deps): update lycheeverse/lychee-action action to v1.5.4
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3831 Re-enabling themes for er diagrams mermaid-js/mermaid
1 participant
@knsv