Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'ESC' Key on item dialog generates empty entry #42

Closed
MichaelHeil opened this issue Feb 8, 2024 · 0 comments · Fixed by #53
Closed

'ESC' Key on item dialog generates empty entry #42

MichaelHeil opened this issue Feb 8, 2024 · 0 comments · Fixed by #53
Labels
bug

Comments

@MichaelHeil
Copy link
Collaborator

MichaelHeil commented Feb 8, 2024 •
edited
Loading

When an item dialog of the generic multifield is being closed/canceled via the "ESC" key, the new node is not being removed again from the repo as it would be on "cancel" button. Hence a item is being added to the field without any properties set.

image
@MichaelHeil MichaelHeil changed the title ESC Key - generates empty entry 'ESC' Key on item dialog generates empty entry Feb 12, 2024
MichaelHeil pushed a commit that referenced this issue Mar 11, 2024
#42 use of qualified class name of usage. Order of import is guaranteed
319a356 
- "const" can not be used within the minifier version of adobe.
@MichaelHeil MichaelHeil linked a pull request Mar 22, 2024 that will close this issue
Resolves 'ESC' Key on item dialog generates empty entry #53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves 'ESC' Key on item dialog generates empty entry merkle-open/aem-generic-multifield
2 participants
@MichaelHeil @darkoBill